You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/02/22 05:38:59 UTC

[GitHub] [rocketmq] fyeeme opened a new pull request #2688: Fix Error architecture image with error content

fyeeme opened a new pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688


   Fix error draw on architecture image 
   
   The detail is on #2686 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on pull request #2688: Fix Error architecture image with error content

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688#issuecomment-783318834


   good catch！


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ShannonDing merged pull request #2688: Fix Error architecture image with error content

Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] fyeeme edited a comment on pull request #2688: Fix Error architecture image with error content

Posted by GitBox <gi...@apache.org>.
fyeeme edited a comment on pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688#issuecomment-783099108


    #2686  is closed due to   the new pr  is created
   @ShannonDing 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-io commented on pull request #2688: Fix Error architecture image with error content

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688#issuecomment-783111710


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2688?src=pr&el=h1) Report
   > Merging [#2688](https://codecov.io/gh/apache/rocketmq/pull/2688?src=pr&el=desc) (d7544d6) into [develop](https://codecov.io/gh/apache/rocketmq/commit/40adaf76df73b00ee9d761c96a0ab2bc039de0b7?el=desc) (40adaf7) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2688/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2688?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2688      +/-   ##
   =============================================
   - Coverage      46.18%   46.17%   -0.02%     
   + Complexity      4343     4340       -3     
   =============================================
     Files            547      547              
     Lines          36246    36246              
     Branches        4809     4809              
   =============================================
   - Hits           16741    16735       -6     
     Misses         17420    17420              
   - Partials        2085     2091       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2688?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh) | `84.61% <0.00%> (-15.39%)` | `7.00% <0.00%> (-2.00%)` | |
   | [.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=) | `38.09% <0.00%> (-9.53%)` | `2.00% <0.00%> (-1.00%)` | |
   | [...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=) | `43.47% <0.00%> (-8.70%)` | `6.00% <0.00%> (-1.00%)` | |
   | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `57.67% <0.00%> (-4.19%)` | `31.00% <0.00%> (-1.00%)` | |
   | [...va/org/apache/rocketmq/common/stats/StatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtLmphdmE=) | `50.00% <0.00%> (-4.17%)` | `10.00% <0.00%> (-2.00%)` | |
   | [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.98% <0.00%> (-3.62%)` | `16.00% <0.00%> (ø%)` | |
   | [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `59.13% <0.00%> (-2.16%)` | `25.00% <0.00%> (-1.00%)` | |
   | [.../rocketmq/client/impl/consumer/PullAPIWrapper.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsQVBJV3JhcHBlci5qYXZh) | `50.42% <0.00%> (-0.86%)` | `12.00% <0.00%> (-1.00%)` | |
   | [.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh) | `63.76% <0.00%> (-0.80%)` | `3.00% <0.00%> (ø%)` | |
   | [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `51.38% <0.00%> (-0.59%)` | `93.00% <0.00%> (-1.00%)` | |
   | ... and [7 more](https://codecov.io/gh/apache/rocketmq/pull/2688/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2688?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2688?src=pr&el=footer). Last update [40adaf7...e291896](https://codecov.io/gh/apache/rocketmq/pull/2688?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #2688: Fix Error architecture image with error content

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688#issuecomment-783104588






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2688: Fix Error architecture image with error content

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688#issuecomment-783104588


   
   [![Coverage Status](https://coveralls.io/builds/37314895/badge)](https://coveralls.io/builds/37314895)
   
   Coverage increased (+0.2%) to 52.117% when pulling **d7544d629935fea55105fdc95704be25d42202f0 on fyeeme:develop** into **40adaf76df73b00ee9d761c96a0ab2bc039de0b7 on apache:develop**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] fyeeme commented on pull request #2688: Fix Error architecture image with error content

Posted by GitBox <gi...@apache.org>.
fyeeme commented on pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688#issuecomment-783099108


    #2686 Can be closed after this or is merged
   @ShannonDing 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] fyeeme commented on pull request #2688: Fix Error architecture image with error content

Posted by GitBox <gi...@apache.org>.
fyeeme commented on pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688#issuecomment-783101238


   diff of the pic 
   ![image](https://user-images.githubusercontent.com/6078758/108667387-0f372500-7514-11eb-8dec-ddcef9063c0a.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky edited a comment on pull request #2688: Fix Error architecture image with error content

Posted by GitBox <gi...@apache.org>.
duhenglucky edited a comment on pull request #2688:
URL: https://github.com/apache/rocketmq/pull/2688#issuecomment-783318834


   good catch！but would you like to submit an issue first？


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org