[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20270: [1.x][submodule] Upgrade oneDNN to v2.2.2

[GitBox <gi...@apache.org>]

bartekkuncer commented on a change in pull request #20270:
URL: https://github.com/apache/incubator-mxnet/pull/20270#discussion_r635350378



##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -430,8 +430,7 @@ void MKLDNNConvolutionForwardFullFeature(const MKLDNNConvFullParam &param, const
       weight.MKLDNNDataReorderAsync(fwd->GetPd().weights_desc());
       weight_mem = GetWeights(weight, fwd->GetPd().weights_desc(), param.conv_param.num_group);
     } else {
-      weight_mem = weight.GetMKLDNNData();
-      CHECK(weight_mem->get_desc() == fwd->GetPd().weights_desc());
+      weight_mem = weight.GetMKLDNNDataReorder(fwd->GetPd().weights_desc());

Review comment:
       Hi @josephevans , sorry for the late response, I must have overlooked your comment. This change is required due to the new oneDNN version, but may fix your customer issue as well. If you sent me a link to the issue I might be able to say something more.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org