You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "JianyuWang0623 (via GitHub)" <gi...@apache.org> on 2024/09/17 13:15:41 UTC
[PR] module/sotest: Try devminor of romdisk [nuttx-apps]
JianyuWang0623 opened a new pull request, #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579
## Summary
For case that /dev/ram${EXAMPLES_SOTEST_DEVMINOR} (e.g. "/dev/ram0") already exists, and users may not care which device to use.
e.g. Try from "/dev/ram0" to "/dev/ram${EXAMPLES_SOTEST_DEVMINOR_MAX} ("/dev/ram5" by default)"
## Impact
examples/sotest
## Testing
- Configuration
```
./tools/configure.sh -l sim:sotest
```
- Runtime
"/dev/ram0", "/dev/ram1" and "/dev/ram2" are already exist, using "/dev/ram3".
```
nsh> sotest
main: Registering romdisk at /dev/ram0
main: Registering romdisk at /dev/ram1
main: Registering romdisk at /dev/ram2
main: Registering romdisk at /dev/ram3
main: Mounting ROMFS filesystem at target=/mnt/romfs with source=/dev/ram3
module_initialize:
module_initialize:
testfunc1: Hello, everyone!
caller: Hello to you too!
testfunc2: Hope you are having a great day!
caller: Not so bad so far.
testfunc3: Let's talk again very soon
caller: Yes, don't be a stranger!
module_uninitialize: arg=0
module_uninitialize: arg=0
nsh>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579#issuecomment-2357434626
@JianyuWang0623 please update defconfig in nuttx git.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "JianyuWang0623 (via GitHub)" <gi...@apache.org>.
JianyuWang0623 commented on PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579#issuecomment-2356893150
> My local testing is strange:
>
> * Linux Debian 12 build (no clipboard to paste here sorry need to create another setup).
> * it shows different results from presented in Testng section (but I have no /dev/ram0..2 existing - how did you create those devices? this part is missing in Testing section).
> * NX `apache:master`, NX-APPS `JianyuWang0623:br_wjy_sotest_try_devminor`: build okay, `sotest` uses `/dev/ram0`.
> * NX-APPS `JianyuWang0623:br_wjy_kernel_sotest_devminor` `JianyuWang0623:br_wjy_kernel_sotest_devminor`: build okay, `sotest` uses `/dev/ram0`.
> * Either using nuttx master or nuttx br_wjy_kernel_sotest_devminor does not affect build of nuttx-apps br_wjy_kernel_sotest_devminor as we can see on the CI o_O
To reproduce CI error, please ref to https://github.com/apache/nuttx/pull/13516, part:
```
$ make distclean
$ ./tools/configure.sh -l sim:sotest
$ make savedefconfig
$ diff defconfig boards/sim/sim/sim/configs/sotest/defconfig
22a23
> CONFIG_EXAMPLES_SOTEST_DEVMINOR=3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "JianyuWang0623 (via GitHub)" <gi...@apache.org>.
JianyuWang0623 commented on PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579#issuecomment-2357456035
> @JianyuWang0623 please update defconfig in nuttx git.
Get, please see https://github.com/apache/nuttx/pull/13516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "JianyuWang0623 (via GitHub)" <gi...@apache.org>.
JianyuWang0623 commented on PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579#issuecomment-2356609126
> Fix CI error of defconfig check: [apache/nuttx#13516](https://github.com/apache/nuttx/pull/13516) (No need to spend time thinking about the choice of devminor maybe.)
Failed job - https://github.com/apache/nuttx-apps/actions/runs/10903856212/job/30258974360?pr=2579:
```
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: boards/sim/sim/sim/configs/sotest/defconfig
modified: boards/sim/sim/sim/configs/sotest32/defconfig
no changes added to commit (use "git add" and/or "git commit -a")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "JianyuWang0623 (via GitHub)" <gi...@apache.org>.
JianyuWang0623 commented on PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579#issuecomment-2356629409
> > Fix CI error of defconfig check: [apache/nuttx#13516](https://github.com/apache/nuttx/pull/13516) (No need to spend time thinking about the choice of devminor maybe.)
>
> Failed job - https://github.com/apache/nuttx-apps/actions/runs/10903856212/job/30258974360?pr=2579:
>
> ```
> On branch master
> Your branch is up to date with 'origin/master'.
>
> Changes not staged for commit:
> (use "git add <file>..." to update what will be committed)
> (use "git restore <file>..." to discard changes in working directory)
> modified: boards/sim/sim/sim/configs/sotest/defconfig
> modified: boards/sim/sim/sim/configs/sotest32/defconfig
>
> no changes added to commit (use "git add" and/or "git commit -a")
> ```
It may be necessary to run CI together with patches from different repositories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "JianyuWang0623 (via GitHub)" <gi...@apache.org>.
JianyuWang0623 commented on PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579#issuecomment-2356876264
> My local testing is strange:
>
> * Linux Debian 12 build (no clipboard to paste here sorry need to create another setup).
> * it shows different results from presented in Testng section (but I have no /dev/ram0..2 existing - how did you create those devices? this part is missing in Testing section).
> * NX `apache:master`, NX-APPS `JianyuWang0623:br_wjy_sotest_try_devminor`: build okay, `sotest` uses `/dev/ram0`.
> * NX-APPS `JianyuWang0623:br_wjy_kernel_sotest_devminor` `JianyuWang0623:br_wjy_kernel_sotest_devminor`: build okay, `sotest` uses `/dev/ram0`.
> * Either using nuttx master or nuttx br_wjy_kernel_sotest_devminor does not affect build of nuttx-apps br_wjy_kernel_sotest_devminor as we can see on the CI o_O
Sorry for not attaching the complete test steps, one way is to create "/dev/ramN" through the "mkrd" command:
```
$ ./nuttx
NuttShell (NSH) NuttX-12.6.0-RC1
nsh> ls /dev/
/dev:
console
loop
null
oneshot
rtc0
zero
nsh> mkrd -m 0 -s 1024 1024
nsh> ls /dev/
/dev:
console
loop
null
oneshot
ram0
rtc0
zero
nsh> mkrd -m 1 -s 1024 1024
nsh> mkrd -m 2 -s 1024 1024
nsh
nsh> ls /dev/
/dev:
console
loop
null
oneshot
ram0
ram1
ram2
rtc0
zero
nsh> sotest
main: Registering romdisk at /dev/ram0
main: Registering romdisk at /dev/ram1
main: Registering romdisk at /dev/ram2
main: Registering romdisk at /dev/ram3
main: Mounting ROMFS filesystem at target=/mnt/romfs with source=/dev/ram3
module_initialize:
module_initialize:
testfunc1: Hello, everyone!
caller: Hello to you too!
testfunc2: Hope you are having a great day!
caller: Not so bad so far.
testfunc3: Let's talk again very soon
caller: Yes, don't be a stranger!
module_uninitialize: arg=0
module_uninitialize: arg=0
nsh>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579#issuecomment-2356703101
Yeah let me build locally to verify changes on both repos :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579#issuecomment-2356781714
My local testing is strange:
* Linux Debian 12 build.
* it shows different results from presented in Testng section (but I have no /dev/ram0..2 existing - how did you create those devices? this part is missing in Testing section).
* NX `apache:master`, NX-APPS `JianyuWang0623:br_wjy_sotest_try_devminor`: build okay, `sotest` uses `/dev/ram0`.
* NX-APPS `JianyuWang0623:br_wjy_kernel_sotest_devminor` `JianyuWang0623:br_wjy_kernel_sotest_devminor`: build okay, `sotest` uses `/dev/ram0`.
* Either using nuttx master or nuttx br_wjy_kernel_sotest_devminor does not affect build of nuttx-apps br_wjy_kernel_sotest_devminor as we can see on the CI o_O
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] module/sotest: Try devminor of romdisk [nuttx-apps]
Posted by "JianyuWang0623 (via GitHub)" <gi...@apache.org>.
JianyuWang0623 commented on PR #2579:
URL: https://github.com/apache/nuttx-apps/pull/2579#issuecomment-2356483640
Fix CI error of defconfig check: https://github.com/apache/nuttx/pull/13516 (No need to spend time thinking about the choice of devminor maybe.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org