[jira] [Commented] (CAMEL-12785) ServletComponent ignores httpBinding option

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611027#comment-16611027 ] 

ASF GitHub Bot commented on CAMEL-12785:
----------------------------------------

vrlgohel opened a new pull request #2517: CAMEL-12785: ServletComponent ignores HttpBinding
URL: https://github.com/apache/camel/pull/2517
 
 
   We dropped the **httpBindingRef** in http common and servlet component some time back. The Servlet Component had a regression where it wasn't taking into consideration a custom **httpBinding**, and instead always initialized a default instance of **ServletRestHttpBinding**, thereby ignoring the custom config. 
   This change now takes into effect **user's custom httpBinding**. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ServletComponent ignores httpBinding option
> -------------------------------------------
>
>                 Key: CAMEL-12785
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12785
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-servlet
>    Affects Versions: 2.18.3
>            Reporter: Paul McCulloch
>            Assignee: Viral Gohel
>            Priority: Major
>
> ServletComponent.doCreateConsumer()  seems to consider the 'httpBindingRef' option when deciding whether or not to create a default HttpBinding. However this option was removed in 2.17 (https://github.com/apache/camel/commit/df701cc3776833c98a3e2b53f86dfd8f01eabe4b )
> {{<restConfiguration component="servlet" enableCORS="true">}}
> {{   <endpointProperty key="servletName" value="MyCamelServlet"/>}}
> {{   <endpointProperty key="httpBinding" value="#MyHttpBinding"/>}}
> {{</restConfiguration>}}
> Doesn't use the custom binding. Providing a value for httpBindingRef causes the endpoint creation to fail (due to unknown parameters being included in the servlet:// URI.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)