[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #316: Add support for ZooKeeper 3.5

[GitBox <gi...@apache.org>]

arvindshmicrosoft commented on a change in pull request #316: Add support for ZooKeeper 3.5
URL: https://github.com/apache/fluo-muchos/pull/316#discussion_r373124214
 
 

 ##########
 File path: lib/muchos/config/base.py
 ##########
 @@ -182,6 +183,10 @@ def _verify_config(self, action):
             if self.java_product_version() >= 11 and StrictVersion(self.version('accumulo').replace('-SNAPSHOT','')) <= StrictVersion("1.9.3"):
                 exit("ERROR - Java 11 is not supported with Accumulo version '{0}'".format(self.version('accumulo')))
 
+            # validate and fail if we are using ZooKeeper 3.5.5 or greater and Accumulo 1.9.x or less
+            if StrictVersion(self.version('zookeeper')) >= StrictVersion("3.5.5") and StrictVersion(self.version('accumulo').replace('-SNAPSHOT','')) < StrictVersion("1.10.0"):
 
 Review comment:
   @ctubbsii one of us will submit a PR for the start-all.sh script early next week.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services