You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/03/02 00:44:44 UTC

[GitHub] [maven-surefire] Tibor17 commented on pull request #339: [SUREFIRE-1890] Support TestNG 7.4.0

Tibor17 commented on pull request #339:
URL: https://github.com/apache/maven-surefire/pull/339#issuecomment-788453318


   > 
   > 
   > Note I'm not sure the best way to write a test for this given it needs to run on at least TestNG 6.9.7+ (based on the enum's existence, I've only tested against TestNG 7.4.0 where it appears to work correctly).
   
   You can write the integration test, see the module `surefire-its`. The unit test is possible but i think you need to extract few lines to a private method and test only that (see `Whitebox.invokeMethod()`).
   
   > 
   > There's also probably some opportunity for a minor refactor to remove the copy / paste of compatible configuration (setting thread count / dataproviderthreadcount ) by abstracting setParallel(), but not sure how worth it that would be?
   
   Let's refactor this code in another PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org