You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/04/28 20:40:08 UTC
[kudu-CR] external mini cluster: pass options by value and move where appropriate
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6760
to review the following change.
Change subject: external mini cluster: pass options by value and move where appropriate
......................................................................
external mini cluster: pass options by value and move where appropriate
I also added a default constructor for the few cases where no option
customization is needed (webserver-stress-itest and master_migration-itest).
Change-Id: I75cb8fb7e1c38ffba0ac4894a732c3d54f59da05
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/log-rolling-itest.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/open-readonly-fs-itest.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/version_migration-test.cc
M src/kudu/integration-tests/webserver-stress-itest.cc
16 files changed, 35 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/6760/1
--
To view, visit http://gerrit.cloudera.org:8080/6760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75cb8fb7e1c38ffba0ac4894a732c3d54f59da05
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] external mini cluster: pass options by value and move where appropriate
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: external mini cluster: pass options by value and move where appropriate
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75cb8fb7e1c38ffba0ac4894a732c3d54f59da05
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] external mini cluster: pass options by value and move where appropriate
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: external mini cluster: pass options by value and move where appropriate
......................................................................
external mini cluster: pass options by value and move where appropriate
I also added a default constructor for the few cases where no option
customization is needed (webserver-stress-itest and master_migration-itest).
Change-Id: I75cb8fb7e1c38ffba0ac4894a732c3d54f59da05
Reviewed-on: http://gerrit.cloudera.org:8080/6760
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/log-rolling-itest.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/open-readonly-fs-itest.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/version_migration-test.cc
M src/kudu/integration-tests/webserver-stress-itest.cc
16 files changed, 35 insertions(+), 25 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75cb8fb7e1c38ffba0ac4894a732c3d54f59da05
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot