You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/04/06 12:07:30 UTC

[GitHub] [kyuubi] codecov-commenter commented on pull request #4669: LDAP authentication allows auth user contains domain when bind.dn/pw enabled

codecov-commenter commented on PR #4669:
URL: https://github.com/apache/kyuubi/pull/4669#issuecomment-1498959116

   ## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4669?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4669](https://codecov.io/gh/apache/kyuubi/pull/4669?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d365bdc) into [master](https://codecov.io/gh/apache/kyuubi/commit/1241a3891431cda602269bd49dcb8621ad77bbb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1241a38) will **decrease** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head d365bdc differs from pull request most recent head b4d1587. Consider uploading reports for the commit b4d1587 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4669      +/-   ##
   ============================================
   - Coverage     57.61%   57.57%   -0.04%     
     Complexity       13       13              
   ============================================
     Files           579      579              
     Lines         31966    31967       +1     
     Branches       4270     4271       +1     
   ============================================
   - Hits          18417    18406      -11     
   - Misses        11785    11797      +12     
     Partials       1764     1764              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kyuubi/pull/4669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...uthentication/LdapAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/kyuubi/pull/4669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0xkYXBBdXRoZW50aWNhdGlvblByb3ZpZGVySW1wbC5zY2FsYQ==) | `78.04% <100.00%> (ø)` | |
   | [...kyuubi/service/authentication/ldap/LdapUtils.scala](https://codecov.io/gh/apache/kyuubi/pull/4669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL2xkYXAvTGRhcFV0aWxzLnNjYWxh) | `87.80% <100.00%> (+0.30%)` | :arrow_up: |
   
   ... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4669/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org