You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/09 10:39:47 UTC
[GitHub] [tvm] Mousius opened a new pull request, #12747: [Target] Print deprecation warning before canonicalisation in build module
Mousius opened a new pull request, #12747:
URL: https://github.com/apache/tvm/pull/12747
Hopefully fixes #12742, as the warning should only be printed when a user passes `target_host`, in the current case if the user passes `None` as `target_host` it'll be processed by `canon_target_map_and_host` which seems to be producing a `target_host` and thus triggering the warning despite the user doing nothing wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #12747: [Target] Print deprecation warning before canonicalisation in build module
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #12747:
URL: https://github.com/apache/tvm/pull/12747#issuecomment-1248627790
thanks @Mousius and sorry for the delay, that looks like a good fix to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #12747: [Target] Print deprecation warning before canonicalisation in build module
Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #12747:
URL: https://github.com/apache/tvm/pull/12747#issuecomment-1241806894
@areusch WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #12747: [Target] Print deprecation warning before canonicalisation in build module
Posted by GitBox <gi...@apache.org>.
areusch merged PR #12747:
URL: https://github.com/apache/tvm/pull/12747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org