You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by wu-sheng <gi...@git.apache.org> on 2017/01/11 07:39:19 UTC
[GitHub] incubator-rocketmq pull request #35: [ROCKETMQ-42] Output is not friendly, w...
GitHub user wu-sheng opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/35
[ROCKETMQ-42] Output is not friendly, when Main failed.
ref issue: https://issues.apache.org/jira/browse/ROCKETMQ-42
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wu-sheng/incubator-rocketmq fix/ROCKETMQ-42
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit 9705e7754d8ae9acf718cf6de3d4114050160a77
Author: wusheng <wu...@foxmail.com>
Date: 2017-01-11T06:27:05Z
fix/ROCKETMQ-42: Add a output before printing the stack, improve the readability of the output
commit 544638da77f475f9b8cec052ba86bfaac3876f73
Author: wusheng <wu...@foxmail.com>
Date: 2017-01-11T06:32:17Z
fix/ROCKETMQ-42: fix style-check failure agai.
commit 44bc3d35387bb574ab376c8e3f76caf56a33506e
Author: wusheng <wu...@foxmail.com>
Date: 2017-01-11T06:53:30Z
fix/ROCKETMQ-42: fix white space again.
commit 15d86f3f7ee90085fb895289119f2f7b91b86a20
Author: wusheng <wu...@foxmail.com>
Date: 2017-01-11T07:28:55Z
fix/ROCKETMQ-42: quick fix
commit 0bffd7a9bf0dbf9ebae76704f1af3822e817b8c0
Author: wusheng <wu...@foxmail.com>
Date: 2017-01-11T07:35:47Z
fix/ROCKETMQ-42: fix style-check.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #35: [ROCKETMQ-42] Output is not friendly, when Mai...
Posted by wu-sheng <gi...@git.apache.org>.
Github user wu-sheng commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/35
@vongosling, your idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #35: [ROCKETMQ-42] Output is not friendly, when Mai...
Posted by wu-sheng <gi...@git.apache.org>.
Github user wu-sheng commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/35
I have known about @shroman 's issue. And I am sure he is right about that log is better than `e.printStackTrace()` or `system.out`. And here, there is a special scene.
Let's focus on `FiltersrvStartup.java`'s change logs. This `system.out` is unavoidable.
* `try-catch` block starts at line 74
* Field `log` is initialized at line 128
If codes occur exception between these two lines, certainly be `catch`ed, and trigger `NullPointException` in catch.
Other changes like this one, this is why I only change these classes, as so many `System.out`s are used in project.
You see, this is also why we need discuss before merge or close. \U0001f60a
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #35: [ROCKETMQ-42] Output is not friendly, w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #35: [ROCKETMQ-42] Output is not friendly, when Mai...
Posted by wu-sheng <gi...@git.apache.org>.
Github user wu-sheng commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/35
Maybe, we should reopen this pull request, and discuss more details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #35: [ROCKETMQ-42] Output is not friendly, when Mai...
Posted by wu-sheng <gi...@git.apache.org>.
Github user wu-sheng commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/35
Whether the pull request be merged or not, the project team should close it without anything.
Using a commit to close, only comment on "won't fix", seem not regular for outside contributors. More communications should stay on GitHub, rather than your inside team, as least have a discussion, and then have a conclusion. In **Apache Software Foundation**, `benevolent dictator` is not welcome, I think you should pay attention to this.
This is only a suggestion, but I think this is important. btw @vongosling @WillemJiang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #35: [ROCKETMQ-42] Output is not friendly, when Mai...
Posted by wu-sheng <gi...@git.apache.org>.
Github user wu-sheng commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/35
I have already explain it before. Generally speaking, `log` is not initialized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #35: [ROCKETMQ-42] Output is not friendly, when Mai...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/35
Hi @wu-sheng , I am sorry for this rash close~
Actually, as @shroman mentioned in this [issue](https://github.com/apache/incubator-rocketmq/pull/3), we also think avoid using `e.printStackTrace()` or `system.out` is a better way, and there are some discussions in this thread.
Finally, thanks for this suggestion, we will have more discussions in GitHub issue before closing a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---