You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2013/09/15 19:53:44 UTC
svn commit: r1523466 -
/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
Author: jleroux
Date: Sun Sep 15 17:53:43 2013
New Revision: 1523466
URL: http://svn.apache.org/r1523466
Log:
As suggested on dev ML, reintroduce findAll("EntityName"), I decided that findAllCache("EntityName") could be also. If you disagree on findAllCache, just remove it...
Modified:
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java?rev=1523466&r1=1523465&r2=1523466&view=diff
==============================================================================
--- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java (original)
+++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java Sun Sep 15 17:53:43 2013
@@ -1673,6 +1673,25 @@ public class GenericDelegator implements
TransactionUtil.commit(beganTransaction);
}
}
+
+ /** Finds all Generic entities
+ *@param entityName The Name of the Entity as defined in the entity XML file
+ *@return List containing all Generic entities
+ *@deprecated Use findList() instead
+ */
+ public List<GenericValue> findAll(String entityName) throws GenericEntityException {
+ return this.findList(entityName, null, null, null, null, false);
+ }
+
+ /** Finds all Generic entities, looking first in the cache
+ *@param entityName The Name of the Entity as defined in the entity XML file
+ *@return List containing all Generic entities
+ *@deprecated Use findList() instead
+ */
+ public List<GenericValue> findAllCache(String entityName) throws GenericEntityException {
+ return this.findList(entityName, null, null, null, null, true);
+ }
+
/* (non-Javadoc)
* @see org.ofbiz.entity.Delegator#findByAnd(java.lang.String, java.lang.Object)
Re: svn commit: r1523466 -
/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Right, I my work was hastily based on R09.04. It's compliant now at revision: 1523507
Jacques
Adrian Crum wrote:
> Don't we need to add these methods to the interface? Also, the new
> pattern is to use a single method with a useCache parameter.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 9/15/2013 10:53 AM, jleroux@apache.org wrote:
>> Author: jleroux
>> Date: Sun Sep 15 17:53:43 2013
>> New Revision: 1523466
>>
>> URL: http://svn.apache.org/r1523466
>> Log:
>> As suggested on dev ML, reintroduce findAll("EntityName"), I decided that findAllCache("EntityName") could be also. If you
>> disagree on findAllCache, just remove it...
>>
>> Modified:
>> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>>
>> Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java?rev=1523466&r1=1523465&r2=1523466&view=diff
>> ============================================================================== ---
>> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java (original) +++
>> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java Sun Sep 15 17:53:43 2013 @@ -1673,6 +1673,25 @@ public
>> class GenericDelegator implements TransactionUtil.commit(beganTransaction);
>> }
>> }
>> +
>> + /** Finds all Generic entities
>> + *@param entityName The Name of the Entity as defined in the entity XML file
>> + *@return List containing all Generic entities
>> + *@deprecated Use findList() instead
>> + */
>> + public List<GenericValue> findAll(String entityName) throws GenericEntityException {
>> + return this.findList(entityName, null, null, null, null, false);
>> + }
>> +
>> + /** Finds all Generic entities, looking first in the cache
>> + *@param entityName The Name of the Entity as defined in the entity XML file
>> + *@return List containing all Generic entities
>> + *@deprecated Use findList() instead
>> + */
>> + public List<GenericValue> findAllCache(String entityName) throws GenericEntityException {
>> + return this.findList(entityName, null, null, null, null, true);
>> + }
>> +
>>
>> /* (non-Javadoc)
>> * @see org.ofbiz.entity.Delegator#findByAnd(java.lang.String, java.lang.Object)
Re: svn commit: r1523466 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
Posted by Adrian Crum <ad...@sandglass-software.com>.
Don't we need to add these methods to the interface? Also, the new
pattern is to use a single method with a useCache parameter.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 9/15/2013 10:53 AM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Sun Sep 15 17:53:43 2013
> New Revision: 1523466
>
> URL: http://svn.apache.org/r1523466
> Log:
> As suggested on dev ML, reintroduce findAll("EntityName"), I decided that findAllCache("EntityName") could be also. If you disagree on findAllCache, just remove it...
>
> Modified:
> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>
> Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java?rev=1523466&r1=1523465&r2=1523466&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java (original)
> +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java Sun Sep 15 17:53:43 2013
> @@ -1673,6 +1673,25 @@ public class GenericDelegator implements
> TransactionUtil.commit(beganTransaction);
> }
> }
> +
> + /** Finds all Generic entities
> + *@param entityName The Name of the Entity as defined in the entity XML file
> + *@return List containing all Generic entities
> + *@deprecated Use findList() instead
> + */
> + public List<GenericValue> findAll(String entityName) throws GenericEntityException {
> + return this.findList(entityName, null, null, null, null, false);
> + }
> +
> + /** Finds all Generic entities, looking first in the cache
> + *@param entityName The Name of the Entity as defined in the entity XML file
> + *@return List containing all Generic entities
> + *@deprecated Use findList() instead
> + */
> + public List<GenericValue> findAllCache(String entityName) throws GenericEntityException {
> + return this.findList(entityName, null, null, null, null, true);
> + }
> +
>
> /* (non-Javadoc)
> * @see org.ofbiz.entity.Delegator#findByAnd(java.lang.String, java.lang.Object)
>
>