You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/03/22 15:54:30 UTC
Review Request 70277: Added a test to ensure quota capacity check
includes reservations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70277/
-----------------------------------------------------------
Review request for mesos and Meng Zhu.
Bugs: MESOS-7883
https://issues.apache.org/jira/browse/MESOS-7883
Repository: mesos
Description
-------
This is done by having a single agent with static reservations,
and requesting quota for the same amount as the reservations.
Note that the quota is not satisfiable despite passing the quota
capacity check.
Diffs
-----
src/tests/master_quota_tests.cpp 3e7a94cad94b64faf01e73f880281d24098fadbd
Diff: https://reviews.apache.org/r/70277/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 70277: Added a test to ensure quota capacity check
includes reservations.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70277/#review213960
-----------------------------------------------------------
Fix it, then Ship it!
In the description:
s/This is done by having a single agent with static reservations/This is done by statically reserving all resources on an agent/
src/tests/master_quota_tests.cpp
Lines 872 (patched)
<https://reviews.apache.org/r/70277/#comment300078>
// We request all resources on the agent, including reservations.
- Meng Zhu
On March 22, 2019, 8:54 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70277/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 8:54 a.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-7883
> https://issues.apache.org/jira/browse/MESOS-7883
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is done by having a single agent with static reservations,
> and requesting quota for the same amount as the reservations.
> Note that the quota is not satisfiable despite passing the quota
> capacity check.
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp 3e7a94cad94b64faf01e73f880281d24098fadbd
>
>
> Diff: https://reviews.apache.org/r/70277/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>