You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Jennifer A Thompson (Created) (JIRA)" <de...@tuscany.apache.org> on 2011/11/01 21:27:32 UTC

[jira] [Created] (TUSCANY-3971) JMSBindingProcessor.writeOperationProperties should trim() properties prior to writing them & update logic to write JMS attributes even if properties are null.

JMSBindingProcessor.writeOperationProperties should trim() properties prior to writing them & update logic to write JMS attributes even if properties are null.
---------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: TUSCANY-3971
                 URL: https://issues.apache.org/jira/browse/TUSCANY-3971
             Project: Tuscany
          Issue Type: Bug
          Components: SCA Java Runtime
    Affects Versions: Java-SCA-2.x
            Reporter: Jennifer A Thompson
             Fix For: Java-SCA-2.x


In the JMSBindingProcessor.writeOperationProperties() method there are two corrections which need to be made.

1) Update logic for writing properties. Currently the logic is
if (operationProperties != null){
      if ((jmsType != null && jmsType.length() > 0) || 
                    (jmsCorrelationId != null && jmsCorrelationId.length() > 0) || 
                    jmsDeliveryMode != null || jmsTimeToLive != null || 
                    jmsPriority != null) {
}

So this will only write jmsType, jmsDeliveryMode and jmsPriority only if there actually are operation properties. However, this may not always be the case. So the logic should be updated to 1 if statement connected with "or" clauses. 


2) Also trim() should be added to 0 length checks, and add possibly added before actually writing the value.  

So the update code would be:
if ( (operationProperties != null && !operationProperties.isEmpty()) || (jmsType != null && jmsType.trim().length() > 0) || 
                    jmsDeliveryMode != null || jmsTimeToLive != null || 
                    jmsPriority != null) {
.....

      if (jmsType != null && jmsType.trim().length() > 0) {
                        writer.writeAttribute("type", jmsType.trim());
      }
........
}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (TUSCANY-3971) JMSBindingProcessor.writeOperationProperties should trim() properties prior to writing them & update logic to write JMS attributes even if properties are null.

Posted by "ant elder (Closed) (JIRA)" <de...@tuscany.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ant elder closed TUSCANY-3971.
------------------------------

    Resolution: Fixed

Fixed by updating as suggested
                
> JMSBindingProcessor.writeOperationProperties should trim() properties prior to writing them & update logic to write JMS attributes even if properties are null.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-3971
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3971
>             Project: Tuscany
>          Issue Type: Bug
>          Components: SCA Java Runtime
>    Affects Versions: Java-SCA-2.x
>            Reporter: Jennifer A Thompson
>             Fix For: Java-SCA-2.x
>
>
> In the JMSBindingProcessor.writeOperationProperties() method there are two corrections which need to be made.
> 1) Update logic for writing properties. Currently the logic is
> if (operationProperties != null){
>       if ((jmsType != null && jmsType.length() > 0) || 
>                     (jmsCorrelationId != null && jmsCorrelationId.length() > 0) || 
>                     jmsDeliveryMode != null || jmsTimeToLive != null || 
>                     jmsPriority != null) {
> }
> So this will only write jmsType, jmsDeliveryMode and jmsPriority only if there actually are operation properties. However, this may not always be the case. So the logic should be updated to 1 if statement connected with "or" clauses. 
> 2) Also trim() should be added to 0 length checks, and add possibly added before actually writing the value.  
> So the update code would be:
> if ( (operationProperties != null && !operationProperties.isEmpty()) || (jmsType != null && jmsType.trim().length() > 0) || 
>                     jmsDeliveryMode != null || jmsTimeToLive != null || 
>                     jmsPriority != null) {
> .....
>       if (jmsType != null && jmsType.trim().length() > 0) {
>                         writer.writeAttribute("type", jmsType.trim());
>       }
> ........
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira