[GitHub] [james-project] woj-tek commented on a diff in pull request #1579: [FIX] JPA blocking calls should be moved to bounded elastic

["woj-tek (via GitHub)" <gi...@apache.org>]

woj-tek commented on code in PR #1579:
URL: https://github.com/apache/james-project/pull/1579#discussion_r1214932320


##########
mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAMessageMapper.java:
##########
@@ -93,6 +94,12 @@ public Flux<MessageUid> listAllMessageUids(Mailbox mailbox) {
             .map(MailboxMessage::getUid);
     }
 
+    @Override
+    public Flux<MailboxMessage> findInMailboxReactive(Mailbox mailbox, MessageRange messageRange, FetchType ftype, int limitAsInt) {
+        return Flux.defer(Throwing.supplier(() -> Flux.fromIterable(findAsList(mailbox.getMailboxId(), messageRange, limitAsInt))).sneakyThrow())

Review Comment:
   Shouldn't internal `Flux` (`Flux.fromIterable(findAsList())`) have same `Schedulers.boundedElastic()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org