[GitHub] [incubator-brpc] jamesge commented on a change in pull request #1214: add option to allow access methods from default url

[GitBox <gi...@apache.org>]

jamesge commented on a change in pull request #1214:
URL: https://github.com/apache/incubator-brpc/pull/1214#discussion_r481085907



##########
File path: src/brpc/server.h
##########
@@ -334,6 +339,7 @@ class Server {
     struct MethodProperty {
         bool is_builtin_service;
         bool own_method_status;
+        bool restful_mapped_only;

Review comment:
       这个要移到下面的params中。

##########
File path: src/brpc/server.h
##########
@@ -277,6 +277,11 @@ struct ServiceOptions {
     // Default: empty
     std::string restful_mappings;
 
+    // Work with restful_mappings, if this flag is true, reject methods accessed
+    // from default urls (SERVICE/METHOD).
+    // Default: true
+    bool restful_mapped_only;

Review comment:
       叫allow_default_url吧，更明确一点。注意改名后，值是相反的。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org