You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/03 00:18:13 UTC
[GitHub] [tvm] codeislife99 opened a new pull request #7397: Fix Bug in Bilinear Interpolation
codeislife99 opened a new pull request #7397:
URL: https://github.com/apache/tvm/pull/7397
This PR fixes a bug in bilinear interpolation which was causing wrong output with deformable convolutions from frameworks. The "bug" occurs when one or more the interpolation index(y, x) is outside one or more of the boundary points(y_max, x_max), but within (y_max + 1, x_max + 1). In the current implementation both interpolation source points are on the boundary. In the corrected version, the first point is on the boundary and the second point value is 0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anijain2305 commented on pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-773785613
Thanks @codeislife99 @vinx13 This is merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 commented on pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
codeislife99 commented on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-773686770
@masahi can you give me a +1 , maybe @vinx13 doesn't have write access and therefore his lgtm didn't work ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 commented on a change in pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
codeislife99 commented on a change in pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#discussion_r570527156
##########
File path: include/tvm/topi/detail/tensor_utils.h
##########
@@ -62,31 +63,39 @@ inline bool is_empty_shape(const Array<PrimExpr>& x) {
*
* \return The interpolated value in the given index.
*/
+
Review comment:
Done.
##########
File path: include/tvm/topi/detail/tensor_utils.h
##########
@@ -62,31 +63,39 @@ inline bool is_empty_shape(const Array<PrimExpr>& x) {
*
* \return The interpolated value in the given index.
*/
+
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 commented on pull request #7397: Fix Bug in Bilinear Interpolation
Posted by GitBox <gi...@apache.org>.
codeislife99 commented on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-772272202
It seems that this is also affecting roi_align operation. While I am confident that this change will positively affect deformable_conv, I am looking into what the exact error was which caused the roi_align failure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 commented on pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
codeislife99 commented on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-773686770
@masahi can you give me a +1 , maybe @vinx13 doesn't have write access and therefore his lgtm didn't work ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on a change in pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
vinx13 commented on a change in pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#discussion_r569923943
##########
File path: include/tvm/topi/detail/tensor_utils.h
##########
@@ -62,31 +63,39 @@ inline bool is_empty_shape(const Array<PrimExpr>& x) {
*
* \return The interpolated value in the given index.
*/
+
Review comment:
nit: remove blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 commented on pull request #7397: Fix Bug in Bilinear Interpolation
Posted by GitBox <gi...@apache.org>.
codeislife99 commented on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-772127397
cc @masahi @t-vi @anijain2305 @comaniac @trevor-m
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anijain2305 merged pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
anijain2305 merged pull request #7397:
URL: https://github.com/apache/tvm/pull/7397
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anijain2305 merged pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
anijain2305 merged pull request #7397:
URL: https://github.com/apache/tvm/pull/7397
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 removed a comment on pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
codeislife99 removed a comment on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-773686770
@masahi can you give me a +1 , maybe @vinx13 doesn't have write access and therefore his lgtm didn't work ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] anijain2305 commented on pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-773785613
Thanks @codeislife99 @vinx13 This is merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-772823882
cc @vinx13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on a change in pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
vinx13 commented on a change in pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#discussion_r569923943
##########
File path: include/tvm/topi/detail/tensor_utils.h
##########
@@ -62,31 +63,39 @@ inline bool is_empty_shape(const Array<PrimExpr>& x) {
*
* \return The interpolated value in the given index.
*/
+
Review comment:
nit: remove blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 commented on a change in pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
codeislife99 commented on a change in pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#discussion_r570527156
##########
File path: include/tvm/topi/detail/tensor_utils.h
##########
@@ -62,31 +63,39 @@ inline bool is_empty_shape(const Array<PrimExpr>& x) {
*
* \return The interpolated value in the given index.
*/
+
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 edited a comment on pull request #7397: Fix Bug in Bilinear Interpolation
Posted by GitBox <gi...@apache.org>.
codeislife99 edited a comment on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-772272202
It seems that this is also affecting roi_align operation. This is because for the roi_align operation, [borders are actually snapped ](https://github.com/pytorch/vision/blob/master/test/test_ops.py#L298) unlike the changed implementation while for the deformable_conv it isn't. I will fix it and push a new commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 edited a comment on pull request #7397: Fix Bug in Bilinear Interpolation
Posted by GitBox <gi...@apache.org>.
codeislife99 edited a comment on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-772272202
It seems that this is also affecting roi_align operation. This is because for the roi_align operation, borders are actually snapped unlike the changed implementation while for the deformable_conv it isn't. I will fix it and push a new commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 removed a comment on pull request #7397: Fix Bug in Bilinear Interpolation
Posted by GitBox <gi...@apache.org>.
codeislife99 removed a comment on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-772272202
It seems that this is also affecting roi_align operation. This is because for the roi_align operation, [borders are actually snapped ](https://github.com/pytorch/vision/blob/master/test/test_ops.py#L298) unlike the changed implementation while for the deformable_conv it isn't. I will fix it and push a new commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 removed a comment on pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
codeislife99 removed a comment on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-773686770
@masahi can you give me a +1 , maybe @vinx13 doesn't have write access and therefore his lgtm didn't work ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 commented on a change in pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
codeislife99 commented on a change in pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#discussion_r570586475
##########
File path: include/tvm/topi/detail/tensor_utils.h
##########
@@ -62,31 +63,39 @@ inline bool is_empty_shape(const Array<PrimExpr>& x) {
*
* \return The interpolated value in the given index.
*/
+
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] codeislife99 edited a comment on pull request #7397: Fix Bug in Bilinear Interpolation and Add Deform Conv to PT FrontEnd
Posted by GitBox <gi...@apache.org>.
codeislife99 edited a comment on pull request #7397:
URL: https://github.com/apache/tvm/pull/7397#issuecomment-772127397
cc @masahi @t-vi @anijain2305 @comaniac @trevor-m @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org