[GitHub] tillrohrmann opened a new pull request #7808: [FLINK-11718][rpc] Add onStart method to RpcEndpoint

[GitBox <gi...@apache.org>]

tillrohrmann opened a new pull request #7808: [FLINK-11718][rpc] Add onStart method to RpcEndpoint
URL: https://github.com/apache/flink/pull/7808
 
 
   ## What is the purpose of the change
   
   Add a dedicated onStart method to the RpcEndpoint which is called when the RpcEndpoint
   is started via the start() method. Due to this change it is no longer necessary for the
   user to override the start() method which is error prone because it always requires to
   call super.start(). Now this contract is explicitly enforced. Moreover, it allows to
   execute the setup logic in the RpcEndpoint's main thread.
   
   ## Brief change log
   
   - Add onStart method to `RcpEndpoint`
   - Port `start` logic to `onStart` method for `Dispatcher`, `ResourceManager`, `TaskExecutor` and `JobMaster`
   - Make `RpcEndpoint#start` final to avoid subclasses to override this method
   
   ## Verifying this change
   
   - Added `AkkaRpcActorTest#testOnStartIsCalledWhenRpcEndpointStarts` and `#testOnStartFails`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services