You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Paul Foxworthy (JIRA)" <ji...@apache.org> on 2011/02/01 08:37:29 UTC

[jira] Created: (OFBIZ-4160) Tax not added for order shipping or promotion

Tax not added for order shipping or promotion
---------------------------------------------

                 Key: OFBIZ-4160
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4160
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Paul Foxworthy


When shipping is calculated for the entire order or a promotion adjustment is made, the relevant tax rows from the TaxAuthorityRateProduct table are not being found.

Here's a patch.

This bug was discovered independently by Sergei Biletnikov.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (OFBIZ-4160) Tax not added for order shipping or promotion

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4160:
--------------------------------------

    Assignee: Jacques Le Roux

> Tax not added for order shipping or promotion
> ---------------------------------------------
>
>                 Key: OFBIZ-4160
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4160
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: rev 1065908
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>         Attachments: OFBIZ-4160_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is made, the relevant tax rows from the TaxAuthorityRateProduct table are not being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-4160) Tax not added for order shipping or promotion

Posted by "Paul Foxworthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4160:
----------------------------------

    Description: 
When shipping is calculated for the entire order or a promotion adjustment is made, the relevant tax rows from the TaxAuthorityRateProduct table are not being found.

Here's a patch.

This bug was discovered independently by Sergei Biletnikov, see http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.

  was:
When shipping is calculated for the entire order or a promotion adjustment is made, the relevant tax rows from the TaxAuthorityRateProduct table are not being found.

Here's a patch.

This bug was discovered independently by Sergei Biletnikov.

    Environment: rev 1065908

> Tax not added for order shipping or promotion
> ---------------------------------------------
>
>                 Key: OFBIZ-4160
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4160
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: rev 1065908
>            Reporter: Paul Foxworthy
>         Attachments: OFBIZ-4160_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is made, the relevant tax rows from the TaxAuthorityRateProduct table are not being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (OFBIZ-4160) Tax not added for order shipping or promotion

Posted by "Paul Foxworthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4160:
----------------------------------

    Attachment: OFBIZ-4160_shipping_tax.patch

> Tax not added for order shipping or promotion
> ---------------------------------------------
>
>                 Key: OFBIZ-4160
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4160
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Paul Foxworthy
>         Attachments: OFBIZ-4160_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is made, the relevant tax rows from the TaxAuthorityRateProduct table are not being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-4160) Tax not added for order shipping or promotion

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994038#comment-12994038 ] 

Jacques Le Roux commented on OFBIZ-4160:
----------------------------------------

Thanks Paul,

Before committing, we need to add an explanation on the screen and a js script enforcing the rule. This will guarantee not further issues for now.

A better solution is explained in this thread http://markmail.org/message/ewvaljuqg3voiy2s


> Tax not added for order shipping or promotion
> ---------------------------------------------
>
>                 Key: OFBIZ-4160
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4160
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: rev 1065908
>            Reporter: Paul Foxworthy
>         Attachments: OFBIZ-4160_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is made, the relevant tax rows from the TaxAuthorityRateProduct table are not being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (OFBIZ-4160) Tax not added for order shipping or promotion

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994748#comment-12994748 ] 

Jacques Le Roux commented on OFBIZ-4160:
----------------------------------------

Paul,

As explained in the thread I committed your (slightly modified: formatting) patch with an explanation on screen at r1070830 in trunk. 
I will later add an enforcing js script, so I don't close this issue yet. When I will close I will open a new one to register the definitive solution to be done (I have also added a FIXME in code with reference to this issue)

Thanks!

> Tax not added for order shipping or promotion
> ---------------------------------------------
>
>                 Key: OFBIZ-4160
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4160
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: rev 1065908
>            Reporter: Paul Foxworthy
>         Attachments: OFBIZ-4160_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is made, the relevant tax rows from the TaxAuthorityRateProduct table are not being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira