You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/03/03 17:31:13 UTC
[GitHub] incubator-brooklyn pull request: Adds mysql test for templating (a...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/539
Adds mysql test for templating (and converts from groovy to java)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/mysql-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/539.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #539
----
commit 817b820b6fd6fd6f3bfda2afdb8f9e82c5dfa66b
Author: Aled Sage <al...@gmail.com>
Date: 2015-03-03T15:57:32Z
Mysql template upload: ensure tmp file is deleted
commit a3f82578619858d9f7b98e8a4af3045e6f6cdca1
Author: Aled Sage <al...@gmail.com>
Date: 2015-03-03T16:16:49Z
Covert MySqlIntegrationTest from groovy to java
commit 6f0d412a7a39146ca7ff62f443c9d29e5d33eaf5
Author: Aled Sage <al...@gmail.com>
Date: 2015-03-03T16:30:36Z
MySql: test that creationScriptContents is template
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds mysql test for templating (a...
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/539
Adds mysql test for templating (and converts from groovy to java)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/mysql-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/539.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #539
----
commit 817b820b6fd6fd6f3bfda2afdb8f9e82c5dfa66b
Author: Aled Sage <al...@gmail.com>
Date: 2015-03-03T15:57:32Z
Mysql template upload: ensure tmp file is deleted
commit a3f82578619858d9f7b98e8a4af3045e6f6cdca1
Author: Aled Sage <al...@gmail.com>
Date: 2015-03-03T16:16:49Z
Covert MySqlIntegrationTest from groovy to java
commit 6f0d412a7a39146ca7ff62f443c9d29e5d33eaf5
Author: Aled Sage <al...@gmail.com>
Date: 2015-03-03T16:30:36Z
MySql: test that creationScriptContents is template
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds mysql test for templating (a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds mysql test for templating (a...
Posted by nakomis <gi...@git.apache.org>.
Github user nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/539#issuecomment-76990386
LGTM, tests pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds mysql test for templating (a...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds mysql test for templating (a...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/539#issuecomment-76980157
@nakomis can you review please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds mysql test for templating (a...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/539#issuecomment-77046646
Thanks; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds mysql test for templating (a...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/539#issuecomment-77046939
Actually; I will wait for jenkins to confirm (given previous test aborted for some reason):
Caused by: java.lang.IllegalStateException: Invalid object ID 28 iota=55
at hudson.remoting.ExportTable.diagnoseInvalidId(ExportTable.java:346)
Closing and re-opening PR to kick off build again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---