Re: [jclouds/jclouds] JCLOUDS-1467 (#1260)

[Daniel Estévez <no...@github.com>]

danielestevez approved this pull request.

Thanks @kazimazar 
I noticed a small difference between here https://aws.amazon.com/blogs/aws/ec2-instance-update-c5-instances-with-local-nvme-storage-c5d/ and some sizes for the c5d instances
Could you please check this info and fix it if needed?
I'll commit it as soon as possible.

> +         .volumes(ImmutableList.<Volume>of(
+                 new VolumeBuilder().type(LOCAL).size(10.0f).device("/dev/sda1").bootDevice(true).durable(false).build(),
+                 new VolumeBuilder().type(LOCAL).size(200.0f).device("/dev/sdb").bootDevice(false).durable(false).build()))
+           .is64Bit(true);
+   }
+
+   /**
+    * @see InstanceType#C5D_4XLARGE
+    */
+   public static EC2HardwareBuilder c5d_4xlarge() {
+      return new EC2HardwareBuilder(InstanceType.C5D_4XLARGE).c5()
+         .ram(32768)
+         .processors(ImmutableList.of(new Processor(16.0, 3.0)))
+         .volumes(ImmutableList.<Volume>of(
+                 new VolumeBuilder().type(LOCAL).size(10.0f).device("/dev/sda1").bootDevice(true).durable(false).build(),
+                 new VolumeBuilder().type(LOCAL).size(400.0f).device("/dev/sdb").bootDevice(false).durable(false).build()))

should be 450.0f

> +         .volumes(ImmutableList.<Volume>of(
+                 new VolumeBuilder().type(LOCAL).size(10.0f).device("/dev/sda1").bootDevice(true).durable(false).build(),
+                 new VolumeBuilder().type(LOCAL).size(100.0f).device("/dev/sdb").bootDevice(false).durable(false).build()))
+           .is64Bit(true);
+   }
+
+   /**
+    * @see InstanceType#C5D_2XLARGE
+    */
+   public static EC2HardwareBuilder c5d_2xlarge() {
+      return new EC2HardwareBuilder(InstanceType.C5D_2XLARGE).c5()
+         .ram(16384)
+         .processors(ImmutableList.of(new Processor(8.0, 3.0)))
+         .volumes(ImmutableList.<Volume>of(
+                 new VolumeBuilder().type(LOCAL).size(10.0f).device("/dev/sda1").bootDevice(true).durable(false).build(),
+                 new VolumeBuilder().type(LOCAL).size(200.0f).device("/dev/sdb").bootDevice(false).durable(false).build()))

should be 225.0f

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1260#pullrequestreview-180574353