You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2020/09/16 06:35:03 UTC
[incubator-superset] 07/28: fix(log): don't log exceptions on test
connection (#10522)
This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch 0.37
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit fb60d302c2d81a7c1c267bcd2f99e3bce43e0c8d
Author: Daniel Vaz Gaspar <da...@gmail.com>
AuthorDate: Thu Aug 6 07:58:22 2020 +0100
fix(log): don't log exceptions on test connection (#10522)
* fix(log): don't log exceptions on test connection
* fix lint
---
superset/views/core.py | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/superset/views/core.py b/superset/views/core.py
index 7f540ab..e7e23b7 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1125,10 +1125,10 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
conn.scalar(select([1]))
return json_success('"OK"')
except CertificateException as ex:
- logger.info(ex.message)
+ logger.info("Certificate exception")
return json_error_response(ex.message)
- except (NoSuchModuleError, ModuleNotFoundError) as ex:
- logger.info("Invalid driver %s", ex)
+ except (NoSuchModuleError, ModuleNotFoundError):
+ logger.info("Invalid driver")
driver_name = make_url(uri).drivername
return json_error_response(
_(
@@ -1137,24 +1137,24 @@ class Superset(BaseSupersetView): # pylint: disable=too-many-public-methods
),
400,
)
- except ArgumentError as ex:
- logger.info("Invalid URI %s", ex)
+ except ArgumentError:
+ logger.info("Invalid URI")
return json_error_response(
_(
"Invalid connection string, a valid string usually follows:\n"
"'DRIVER://USER:PASSWORD@DB-HOST/DATABASE-NAME'"
)
)
- except OperationalError as ex:
- logger.warning("Connection failed %s", ex)
+ except OperationalError:
+ logger.warning("Connection failed")
return json_error_response(
- _("Connection failed, please check your connection settings."), 400
+ _("Connection failed, please check your connection settings"), 400
)
except DBSecurityException as ex:
- logger.warning("Stopped an unsafe database connection. %s", ex)
+ logger.warning("Stopped an unsafe database connection")
return json_error_response(_(str(ex)), 400)
except Exception as ex: # pylint: disable=broad-except
- logger.error("Unexpected error %s", ex)
+ logger.error("Unexpected error %s", type(ex).__name__)
return json_error_response(
_("Unexpected error occurred, please check your logs for details"), 400
)