[GitHub] [madlib] orhankislal commented on a diff in pull request #594: WCC: Add warm start

["orhankislal (via GitHub)" <gi...@apache.org>]

orhankislal commented on code in PR #594:
URL: https://github.com/apache/madlib/pull/594#discussion_r1110235678


##########
src/ports/postgres/modules/graph/wcc.py_in:
##########
@@ -47,14 +48,18 @@ from graph_utils import validate_output_and_summary_tables
 
 def validate_wcc_args(schema_madlib, vertex_table, vertex_id, edge_table,
                       edge_params, out_table, out_table_summary,
-                      grouping_cols_list, module_name):
+                      grouping_cols_list, warm_start, module_name):
     """
     Function to validate input parameters for wcc
     """
     validate_graph_coding(vertex_table, vertex_id, edge_table, edge_params,
-                          out_table, module_name)
-    _assert(not table_exists(out_table_summary),
-            "Graph {module_name}: Output summary table already exists!".format(**locals()))
+                          out_table, module_name, warm_start)
+    if not warm_start:

Review Comment:
   It should, but that requires changes in the rest of the graph modules since `validate_graph_coding` is common.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org