You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by maverickmishra <gi...@git.apache.org> on 2017/08/10 18:28:07 UTC

[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...

GitHub user maverickmishra opened a pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/57

    CB-13068: Updated README to point to transition blog post and show cu…

    ### Platforms affected
    iOS, Android and Windows
    
    ### What does this PR do?
    This PR adds a deprecation notice and points to a transition blog post


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maverickmishra/cordova-plugin-device-motion master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device-motion/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit 69898c4f5d7094dcd5661f6b4f61610e1441d701
Author: maverickmishra <vi...@gmail.com>
Date:   2017-08-10T00:50:50Z

    CB-13068: Updated README to point to transition blog post and show current status

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

Posted by maverickmishra <gi...@git.apache.org>.
Github user maverickmishra commented on the issue:

    https://github.com/apache/cordova-plugin-device-motion/pull/57
  
    Yes, but I thought that issue was superseded by CB-13068. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...

Posted by maverickmishra <gi...@git.apache.org>.
Github user maverickmishra closed the pull request at:

    https://github.com/apache/cordova-plugin-device-motion/pull/57


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-plugin-device-motion/pull/57
  
    Isn't this at odds with @macdonst's PR open in #53 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...

Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r139333464
  
    --- Diff: README.md ---
    @@ -27,6 +27,18 @@ description: Access accelerometer data.
     
     # cordova-plugin-device-motion
     
    +# Deprecation Notice
    +
    +With the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) now
    +being supported on iOS, Android and Windows devices, this plugin is not needed any more. Migrating from this
    +plugin to the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/)
    +is explained in this [PhoneGap blog post](https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed).
    --- End diff --
    
    The plugins release blog post will talk about the deprecation. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-plugin-device-motion/pull/57
  
    I'd also suggest we add an [`<info>` tag to the plugin.xml](https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#info) where we can be more noisy about the deprecation status of the plugin (as it will be printed out during plugin install).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:

    https://github.com/apache/cordova-plugin-device-motion/pull/57
  
    Merged this in, Added `info` tag. 
    
    @maverickmishra can you close this issue?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...

Posted by janpio <gi...@git.apache.org>.
Github user janpio commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r132629591
  
    --- Diff: README.md ---
    @@ -27,6 +27,18 @@ description: Access accelerometer data.
     
     # cordova-plugin-device-motion
     
    +# Deprecation Notice
    +
    +With the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/) now
    +being supported on iOS, Android and Windows devices, this plugin is not needed any more. Migrating from this
    +plugin to the [W3C Device Motion and Orientation API](https://www.w3.org/TR/2016/CR-orientation-event-20160818/)
    +is explained in this [PhoneGap blog post](https://blog.phonegap.com/migrating-from-the-cordova-device-motion-plugin-ddd8176632ed).
    --- End diff --
    
    Why a Phonegap blogpost on a Cordova plugin deprecation?
    
    Shouldn't there at least be a Cordova "we deprecate those plugins" blog post linked here and then maybe additionally a Phonegap blogpost with "this is how you do it now" (although I would of course prefer those at Cordova as well, much less confusing for users re Cordova/Phonegap).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-plugin-device-motion/pull/57
  
    Yeah but it's basically the same stuff, no? I think we should combine what you two have done. I like that you link to the transition blog post. I like that Simon also updated the plugin and package json files. Thoughts @macdonst ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org