You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "rohityadavcloud (via GitHub)" <gi...@apache.org> on 2024/04/25 05:10:07 UTC
[PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
rohityadavcloud opened a new pull request, #8974:
URL: https://github.com/apache/cloudstack/pull/8974
This excludes indirect dependencies of vapi-authentication to allow build to work, with mvn 3.9 on Darwin environments.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [x] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [x] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested as a local build on this env:
```
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /opt/homebrew/Cellar/maven/3.9.6/libexec
Java version: 11.0.16.1, vendor: Homebrew, runtime: /opt/homebrew/Cellar/openjdk@11/11.0.16.1_1/libexec/openjdk.jdk/Contents/Home
Default locale: en_IN, platform encoding: UTF-8
OS name: "mac os x", version: "14.4.1", arch: "aarch64", family: "mac"
```
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077703569
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2076379333
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8974?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.27%. Comparing base [(`836ef9e`)](https://app.codecov.io/gh/apache/cloudstack/commit/836ef9ec709a30f85d2269f31fb475cf94254852?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6735dd1`)](https://app.codecov.io/gh/apache/cloudstack/pull/8974?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8974 +/- ##
============================================
- Coverage 15.28% 4.27% -11.02%
============================================
Files 5425 363 -5062
Lines 473878 29549 -444329
Branches 58286 5188 -53098
============================================
- Hits 72453 1262 -71191
+ Misses 393368 28145 -365223
+ Partials 8057 142 -7915
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8974/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.27% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8974/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8974?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2080322814
<b>[SF] Trillian test result (tid-10046)</b>
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8
Total time taken: 56860 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8974-t10046-vmware-70u3.zip
Smoke tests completed. 125 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_events_resource | `Error` | 362.00 | test_events_resource.py
test_deploy_more_vms_than_limit_allows | `Error` | 159.03 | test_deploy_vms_in_parallel.py
test_04_list_domains_level_filter | `Failure` | 0.08 | test_list_domains.py
test_05_list_domains_no_filter | `Failure` | 0.04 | test_list_domains.py
test_05_list_volumes_isrecursive | `Failure` | 0.08 | test_list_volumes.py
test_07_list_volumes_listall | `Failure` | 0.11 | test_list_volumes.py
test_list_system_vms_metrics_history | `Failure` | 0.30 | test_metrics_api.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2076469303
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2076370445
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077705259
@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2079038366
@rohityadavcloud a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077433882
@blueorangutan test alma8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077583606
<b>[SF] Trillian Build Failed (tid-10031)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2078782644
looks ok
I am not able to reproduce the issue in ubuntu 22.04
```
# /root/apache-maven-3.9.6/bin/mvn -Dnoredist dependency:tree -pl plugins/network-elements/nsx/ -X
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /root/apache-maven-3.9.6
Java version: 11.0.22, vendor: Ubuntu, runtime: /usr/lib/jvm/java-11-openjdk-amd64
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-83-generic", arch: "amd64", family: "unix"
...
[INFO] org.apache.cloudstack:cloud-plugin-network-nsx:jar:4.20.0.0-SNAPSHOT
[INFO] +- com.vmware:nsx-java-sdk:jar:4.1.0.2.0:compile
[INFO] +- com.vmware:nsx-gpm-java-sdk:jar:4.1.0.2.0:compile
[INFO] +- com.vmware:nsx-policy-java-sdk:jar:4.1.0.2.0:compile
[INFO] +- com.vmware.vapi:vapi-authentication:jar:2.40.0:compile
[INFO] +- com.vmware.vapi:vapi-runtime:jar:2.40.0:compile
[INFO] +- org.apache.cloudstack:cloud-server:jar:4.20.0.0-SNAPSHOT:compile
[INFO] | +- commons-io:commons-io:jar:2.8.0:compile
[INFO] | +- org.springframework:spring-web:jar:5.3.26:compile
[INFO] | | \- org.springframework:spring-beans:jar:5.3.26:compile
[INFO] | +- org.apache.cloudstack:cloud-core:jar:4.20.0.0-SNAPSHOT:compile
[INFO] | +- org.apache.cloudstack:cloud-framework-cluster:jar:4.20.0.0-SNAPSHOT:compile
[INFO] | +- org.apache.cloudstack:cloud-framework-security:jar:4.20.0.0-SNAPSHOT:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2076368786
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2079174483
<b>[SF] Trillian test result (tid-10035)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48126 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8974-t10035-kvm-centos7.zip
Smoke tests completed. 128 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_events_resource | `Error` | 425.63 | test_events_resource.py
test_02_trigger_shutdown | `Failure` | 352.02 | test_safe_shutdown.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2077438502
@rohityadavcloud a [SL] Trillian-Jenkins test job (alma8 mgmt + vmware-70u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2079036111
@blueorangutan test alma8 vmware-70u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org