You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2015/11/16 16:36:47 UTC
Re: Review Request 40349: Added tests for use of mtime in fetcher
cache.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40349/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 3:36 p.m.)
Review request for mesos and Bernd Mathiske.
Changes
-------
Remove `WIP` tag since not WIP anymore.
Summary (updated)
-----------------
Added tests for use of mtime in fetcher cache.
Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785
Repository: mesos
Description
-------
Added tests for use of mtime in fetcher cache.
Diffs
-----
src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0
src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
src/tests/fetcher_cache_tests.cpp 7060a151f8812e9fef654419377991970ab8b961
Diff: https://reviews.apache.org/r/40349/diff/
Testing
-------
make check under OS X and ubuntu-trusty.
Thanks,
Benjamin Bannier
Re: Review Request 40349: Added tests for use of mtime in fetcher
cache.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40349/#review106677
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On Nov. 16, 2015, 3:44 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40349/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 3:44 p.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-3856
> https://issues.apache.org/jira/browse/MESOS-3856
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for use of mtime in fetcher cache.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0
> src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
> src/tests/fetcher_cache_tests.cpp 7060a151f8812e9fef654419377991970ab8b961
>
> Diff: https://reviews.apache.org/r/40349/diff/
>
>
> Testing
> -------
>
> make check under OS X and ubuntu-trusty.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 40349: Added tests for use of mtime in fetcher
cache.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40349/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 3:44 p.m.)
Review request for mesos and Bernd Mathiske.
Changes
-------
Linked correct issue.
Bugs: MESOS-3856
https://issues.apache.org/jira/browse/MESOS-3856
Repository: mesos
Description
-------
Added tests for use of mtime in fetcher cache.
Diffs
-----
src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0
src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1
src/tests/fetcher_cache_tests.cpp 7060a151f8812e9fef654419377991970ab8b961
Diff: https://reviews.apache.org/r/40349/diff/
Testing
-------
make check under OS X and ubuntu-trusty.
Thanks,
Benjamin Bannier