[GitHub] [airflow] mik-laj commented on a change in pull request #5549: change task_dict type to Dict[str, BaseOperator] in the comment

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #5549: change task_dict type to Dict[str, BaseOperator] in the comment
URL: https://github.com/apache/airflow/pull/5549#discussion_r302139123
 
 

 ##########
 File path: airflow/models/dag.py
 ##########
 @@ -225,7 +226,7 @@ def __init__(
         self._description = description
         # set file location to caller source path
         self.fileloc = sys._getframe().f_back.f_code.co_filename
-        self.task_dict = dict()  # type: Dict[str, TaskInstance]
+        self.task_dict = dict()  # type: Dict[str, BaseOperator]
 
 Review comment:
   ```suggestion
           self.task_dict:  Dict[str, BaseOperator] = dict()
   ```
   On master, we aim to Python 3+.  In the lines above - 206, we use this type of annotation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services