You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/02/24 12:40:14 UTC

Review Request 18421: RMF. Lazy failing on wrong configuration access is broken

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18421/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-4799
    https://issues.apache.org/jira/browse/AMBARI-4799


Repository: ambari


Description
-------

When we access the configuration which is not actually send from server, we should get exception early on access, rather than just hang until something breaks.


Diffs
-----

  ambari-agent/src/main/python/resource_management/libraries/script/config_dictionary.py ab94d60 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 2bc7430 

Diff: https://reviews.apache.org/r/18421/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 18421: RMF. Lazy failing on wrong configuration access is broken

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18421/#review35266
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Feb. 24, 2014, 11:40 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18421/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 11:40 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-4799
>     https://issues.apache.org/jira/browse/AMBARI-4799
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When we access the configuration which is not actually send from server, we should get exception early on access, rather than just hang until something breaks.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/resource_management/libraries/script/config_dictionary.py ab94d60 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 2bc7430 
> 
> Diff: https://reviews.apache.org/r/18421/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>