You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/10/28 16:17:00 UTC
[jira] [Commented] (NIFI-9322) OIDC and SAML Access Resources
Produce Invalid Documentation
[ https://issues.apache.org/jira/browse/NIFI-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435533#comment-17435533 ]
ASF subversion and git services commented on NIFI-9322:
-------------------------------------------------------
Commit 9865ea2bfbb50682f322377dbd42830c15e5915f in nifi's branch refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9865ea2 ]
NIFI-9322 Refactored OIDC and SAML Access Resources
- Removed parent AccessResource from OIDCAccessResource and SAMLAccessResource to avoid unexpected inherited methods
- Moved Token Expiration validation from AccessResource to StandardBearerTokenProvider
Signed-off-by: Nathan Gough <th...@gmail.com>
This closes #5489.
> OIDC and SAML Access Resources Produce Invalid Documentation
> ------------------------------------------------------------
>
> Key: NIFI-9322
> URL: https://issues.apache.org/jira/browse/NIFI-9322
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.14.0
> Reporter: Dheeraj Joshi
> Assignee: David Handermann
> Priority: Minor
> Fix For: 1.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Nifi API guide at [https://nifi.apache.org/docs/nifi-docs/rest-api/index.html] has an API
> {code:java}
> /access/oidc/token{code}
> However this API is missing from the actual code at
> {code:java}
> OIDCAccessResource.java{code}
> Exposed API's are defined as constants in
> {code:java}
> OIDCEndpoints.java{code}
> And the constants are
> {code:java}
> package org.apache.nifi.web.security.oidc;
> public interface OIDCEndpoints {
> String OIDC_ACCESS_ROOT = "/access/oidc";
> String LOGIN_REQUEST_RELATIVE = "/request";
> String LOGIN_REQUEST = OIDC_ACCESS_ROOT + LOGIN_REQUEST_RELATIVE;
> String LOGIN_CALLBACK_RELATIVE = "/callback";
> String LOGIN_CALLBACK = OIDC_ACCESS_ROOT + LOGIN_CALLBACK_RELATIVE;
> String TOKEN_EXCHANGE_RELATIVE = "/exchange";
> String TOKEN_EXCHANGE = OIDC_ACCESS_ROOT + TOKEN_EXCHANGE_RELATIVE;
> String LOGOUT_REQUEST_RELATIVE = "/logout";
> String LOGOUT_REQUEST = OIDC_ACCESS_ROOT + LOGOUT_REQUEST_RELATIVE;
> String LOGOUT_CALLBACK_RELATIVE = "/logoutCallback";
> String LOGOUT_CALLBACK = OIDC_ACCESS_ROOT + LOGOUT_CALLBACK_RELATIVE;
> }
> {code}
> We were trying to execute the API
> {code:java}
> /access/oidc/token{code}
> to no avail only to realize no such API is exposed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)