You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/02/05 02:27:59 UTC
[jira] Created: (ZOOKEEPER-292) commit configure scripts
(autotools) to svn for c projects and include in release
commit configure scripts (autotools) to svn for c projects and include in release
---------------------------------------------------------------------------------
Key: ZOOKEEPER-292
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
Project: Zookeeper
Issue Type: Improvement
Components: c client, contrib-zkfuse
Reporter: Patrick Hunt
Fix For: 3.2.0
We currently don't include configure scripts, just the .ac file itself. This means that users are required
to run "autoreconf; ./configure" rather than just configure.
We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse).
Also these should be included in the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-292) commit configure scripts
(autotools) to svn for c projects and include in release
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-292:
-----------------------------------
Attachment: ZOOKEEPER-292.patch
After reviewing the autotools typical practices wrt commit to SCCS it looks like a number of projects don't commit this. However they do include the configure script (etc) in the release package.
I've updated build.xml tar/package targets to:
1) build the configure script in src/c
2) include the configure scripts in the release tar
3) set the "x" (executable) flag in the tar
This will fail hudson bot due to no tests changed.
This is blocked by ZOOKEEPER-376 (needs a change made there).
make patch avail after 376 goes in.
> commit configure scripts (autotools) to svn for c projects and include in release
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-292
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, contrib-zkfuse
> Reporter: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-292.patch
>
>
> We currently don't include configure scripts, just the .ac file itself. This means that users are required
> to run "autoreconf; ./configure" rather than just configure.
> We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse).
> Also these should be included in the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-292) commit configure scripts
(autotools) to svn for c projects and include in release
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670836#action_12670836 ]
Patrick Hunt commented on ZOOKEEPER-292:
----------------------------------------
Maxim, not sure what you mean by your comment feb5. When I run
make CFLAGS=-O3
results in:
gcc -DHAVE_CONFIG_H -I. -I. -I. -Iinclude -Igenerated -Wall -Werror -O3 -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
rather than: (with just "make"):
gcc -DHAVE_CONFIG_H -I. -I. -I. -Iinclude -Igenerated -Wall -Werror -g -O2 -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
so for me the build does use this value when compiling. Could you be more explicit?
> commit configure scripts (autotools) to svn for c projects and include in release
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-292
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, contrib-zkfuse
> Reporter: Patrick Hunt
> Fix For: 3.2.0
>
>
> We currently don't include configure scripts, just the .ac file itself. This means that users are required
> to run "autoreconf; ./configure" rather than just configure.
> We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse).
> Also these should be included in the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-292) commit configure scripts
(autotools) to svn for c projects and include in release
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711237#action_12711237 ]
Benjamin Reed commented on ZOOKEEPER-292:
-----------------------------------------
+1 ready to commit
> commit configure scripts (autotools) to svn for c projects and include in release
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-292
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, contrib-zkfuse
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-292.patch
>
>
> We currently don't include configure scripts, just the .ac file itself. This means that users are required
> to run "autoreconf; ./configure" rather than just configure.
> We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse).
> Also these should be included in the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-292) commit configure scripts
(autotools) to svn for c projects and include in release
Posted by "Maxim P. Dementiev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670712#action_12670712 ]
Maxim P. Dementiev commented on ZOOKEEPER-292:
----------------------------------------------
Patrick, sorry for my perseverance but...
What about CFLAGS and CXXFLAGS?
Build system doesn't take them into account.
Should I create an issue (jira item) for this?
> commit configure scripts (autotools) to svn for c projects and include in release
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-292
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, contrib-zkfuse
> Reporter: Patrick Hunt
> Fix For: 3.2.0
>
>
> We currently don't include configure scripts, just the .ac file itself. This means that users are required
> to run "autoreconf; ./configure" rather than just configure.
> We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse).
> Also these should be included in the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-292) commit configure scripts
(autotools) to svn for c projects and include in release
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-292:
---------------------------------------
Assignee: Patrick Hunt
> commit configure scripts (autotools) to svn for c projects and include in release
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-292
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, contrib-zkfuse
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-292.patch
>
>
> We currently don't include configure scripts, just the .ac file itself. This means that users are required
> to run "autoreconf; ./configure" rather than just configure.
> We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse).
> Also these should be included in the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-292) commit configure scripts
(autotools) to svn for c projects and include in release
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711891#action_12711891 ]
Hudson commented on ZOOKEEPER-292:
----------------------------------
Integrated in ZooKeeper-trunk #321 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])
> commit configure scripts (autotools) to svn for c projects and include in release
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-292
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, contrib-zkfuse
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-292.patch
>
>
> We currently don't include configure scripts, just the .ac file itself. This means that users are required
> to run "autoreconf; ./configure" rather than just configure.
> We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse).
> Also these should be included in the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-292) commit configure scripts
(autotools) to svn for c projects and include in release
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-292:
-----------------------------------
Status: Patch Available (was: Open)
the blocking bug has been fixed, submitting patch for review/commit.
> commit configure scripts (autotools) to svn for c projects and include in release
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-292
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, contrib-zkfuse
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-292.patch
>
>
> We currently don't include configure scripts, just the .ac file itself. This means that users are required
> to run "autoreconf; ./configure" rather than just configure.
> We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse).
> Also these should be included in the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-292) commit configure scripts
(autotools) to svn for c projects and include in release
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-292:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed revision 776798.
> commit configure scripts (autotools) to svn for c projects and include in release
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-292
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, contrib-zkfuse
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-292.patch
>
>
> We currently don't include configure scripts, just the .ac file itself. This means that users are required
> to run "autoreconf; ./configure" rather than just configure.
> We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse).
> Also these should be included in the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.