You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/05/22 23:31:21 UTC
Review Request 21828: Use asynchronous transport in Thrift.js client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21828/
-----------------------------------------------------------
Review request for Aurora, Suman Karumuri and Bill Farner.
Bugs: AURORA-463
https://issues.apache.org/jira/browse/AURORA-463
Repository: aurora
Description
-------
JavaScript thrift bindings need to be generated with js:query rather than js to get asynchronous XMLHttpRequest support.
Diffs
-----
build.gradle d22038503a7bf894c335d8a446dbd936abf58516
Diff: https://reviews.apache.org/r/21828/diff/
Testing
-------
./gradlew clean build && ./gradlew clean run
Thanks,
David McLaughlin
Re: Review Request 21828: Use asynchronous transport in Thrift.js client
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21828/#review44142
-----------------------------------------------------------
Ping.
- David McLaughlin
On May 22, 2014, 9:31 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21828/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 9:31 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Bill Farner.
>
>
> Bugs: AURORA-463
> https://issues.apache.org/jira/browse/AURORA-463
>
>
> Repository: aurora
>
>
> Description
> -------
>
> JavaScript thrift bindings need to be generated with js:query rather than js to get asynchronous XMLHttpRequest support.
>
>
> Diffs
> -----
>
> build.gradle d22038503a7bf894c335d8a446dbd936abf58516
>
> Diff: https://reviews.apache.org/r/21828/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build && ./gradlew clean run
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 21828: Use asynchronous transport in Thrift.js client
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21828/#review43781
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On May 22, 2014, 9:31 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21828/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 9:31 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Bill Farner.
>
>
> Bugs: AURORA-463
> https://issues.apache.org/jira/browse/AURORA-463
>
>
> Repository: aurora
>
>
> Description
> -------
>
> JavaScript thrift bindings need to be generated with js:query rather than js to get asynchronous XMLHttpRequest support.
>
>
> Diffs
> -----
>
> build.gradle d22038503a7bf894c335d8a446dbd936abf58516
>
> Diff: https://reviews.apache.org/r/21828/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build && ./gradlew clean run
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 21828: Use asynchronous transport in Thrift.js client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21828/#review44175
-----------------------------------------------------------
Pushed to master. Please close out this review.
- Suman Karumuri
On May 22, 2014, 9:31 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21828/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 9:31 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Bill Farner.
>
>
> Bugs: AURORA-463
> https://issues.apache.org/jira/browse/AURORA-463
>
>
> Repository: aurora
>
>
> Description
> -------
>
> JavaScript thrift bindings need to be generated with js:query rather than js to get asynchronous XMLHttpRequest support.
>
>
> Diffs
> -----
>
> build.gradle d22038503a7bf894c335d8a446dbd936abf58516
>
> Diff: https://reviews.apache.org/r/21828/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build && ./gradlew clean run
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 21828: Use asynchronous transport in Thrift.js client
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21828/#review44173
-----------------------------------------------------------
Ship it!
Ship It!
- Suman Karumuri
On May 22, 2014, 9:31 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21828/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 9:31 p.m.)
>
>
> Review request for Aurora, Suman Karumuri and Bill Farner.
>
>
> Bugs: AURORA-463
> https://issues.apache.org/jira/browse/AURORA-463
>
>
> Repository: aurora
>
>
> Description
> -------
>
> JavaScript thrift bindings need to be generated with js:query rather than js to get asynchronous XMLHttpRequest support.
>
>
> Diffs
> -----
>
> build.gradle d22038503a7bf894c335d8a446dbd936abf58516
>
> Diff: https://reviews.apache.org/r/21828/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build && ./gradlew clean run
>
>
> Thanks,
>
> David McLaughlin
>
>