You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/16 05:27:11 UTC
[GitHub] [incubator-druid] vogievetsky commented on issue #7657: Deleted
created_time in "status"
vogievetsky commented on issue #7657: Deleted created_time in "status"
URL: https://github.com/apache/incubator-druid/pull/7657#issuecomment-492922064
This is not the correct approach to this issue it effectively undoes the tie-breaker reverting back to the state where the tasks are ordered incorrectly:
(see how the time within successful tasks is ascending, it should be descending)
The correct approach is to define a `toString` method on the object returned by the accessor.
Have a look at what I did in this backport PR: https://github.com/apache/incubator-druid/pull/7672/files#diff-4aaac42e3d5f769f344608b14e686f88R604
This gives that object a canonical string value and tricks ReactTable to work as intended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org