You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/28 04:48:49 UTC
[GitHub] [airflow] zarrarrana opened a new pull request #15562: Fix changing the parent dag state on subdag clear
zarrarrana opened a new pull request #15562:
URL: https://github.com/apache/airflow/pull/15562
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Closes: https://github.com/apache/airflow/issues/15374
This pull request follows https://github.com/apache/airflow/pull/14776.
Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zarrarrana commented on pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
zarrarrana commented on pull request #15562:
URL: https://github.com/apache/airflow/pull/15562#issuecomment-828959352
@ashb @kaxil @turbaszek @XD-DENG
Can someone please approve the CI workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15562:
URL: https://github.com/apache/airflow/pull/15562#issuecomment-828140747
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zarrarrana commented on pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
zarrarrana commented on pull request #15562:
URL: https://github.com/apache/airflow/pull/15562#issuecomment-829636037
@ashb @kaxil please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zarrarrana closed pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
zarrarrana closed pull request #15562:
URL: https://github.com/apache/airflow/pull/15562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zarrarrana commented on pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
zarrarrana commented on pull request #15562:
URL: https://github.com/apache/airflow/pull/15562#issuecomment-829639213
@kaxil @ashb
I accidently closed the PR, could you approve the CI workflow again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15562:
URL: https://github.com/apache/airflow/pull/15562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15562:
URL: https://github.com/apache/airflow/pull/15562#issuecomment-829289629
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zarrarrana commented on pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
zarrarrana commented on pull request #15562:
URL: https://github.com/apache/airflow/pull/15562#issuecomment-830275075
Hi @kaxil do you know what the next step is, it still says 1 workflow awaiting approval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15562:
URL: https://github.com/apache/airflow/pull/15562#issuecomment-830344605
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15562:
URL: https://github.com/apache/airflow/pull/15562#issuecomment-829646280
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yuqian90 commented on pull request #15562: Fix changing the parent dag state on subdag clear
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on pull request #15562:
URL: https://github.com/apache/airflow/pull/15562#issuecomment-846340998
This PR fixed some issues but isn't a complete fix (there are other ways the cleared TaskInstance can involve multiple DAGs. See [Cross-DAG Dependencies](https://airflow.apache.org/docs/apache-airflow/stable/howto/operator/external_task_sensor.html#cross-dag-dependencies)). I put up another PR some time ago which should fix the remaining issues as well as the issue this PR reported: https://github.com/apache/airflow/pull/15382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org