[GitHub] [trafficcontrol] zrhoffman opened a new issue #5754: API v1 monitoring.json Profile Parameters no longer contain `health.threshold.*`

[GitBox <gi...@apache.org>]

zrhoffman opened a new issue #5754:
URL: https://github.com/apache/trafficcontrol/issues/5754


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
   or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
   -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  bug report
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  Traffic Monitor
   -  Traffic Ops
   
   ## Current behavior:
   <!-- Describe how the bug manifests -->
   The `/api/1.3/cdns/{name}/configs/monitoring.json` and `/api/2.0/cdns/{name}/configs/monitoring.json` return Profiles with Health Threshold parameters structured differently than ATC 4.1.1 and before had them in. What they look like at 473d9c2422:
   
   ```json
             "health_threshold": {
               "availableBandwidthInKbps": {
                 "Comparator": ">",
                 "Val": 1750000
               },
               "loadavg": {
                 "Comparator": "<",
                 "Val": 25
               },
               "queryTime": {
                 "Comparator": "<",
                 "Val": 1000
               }
   ```
   
   ## Expected behavior:
   <!-- Describe what the behavior would be without the bug -->
   The `/api/1.3/cdns/{name}/configs/monitoring.json` and `/api/2.0/cdns/{name}/configs/monitoring.json` should use the same format as previous releases used:
      https://github.com/apache/trafficcontrol/blob/473d9c242247618f17ac64a2b4e53e7e14fdc7ed/docs/source/api/v2/cdns_name_configs_monitoring.rst#L197-L199
   
   ## Minimal reproduction of the problem with instructions:
   <!--
   If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
   include the applicable TC version.
   -->
   1. `GET /api/1.3/cdns/{name}/configs/monitoring.json`
   2. Notice the Health Threshold Paramters are not in the expected format given above.
   
   
   ## Anything else:
   <!--
   e.g. stacktraces, related issues, suggestions how to fix (feel free to delete
   this section)
   -->
   Attached:
   - [A monitoring.json from RELEASE-4.1.1onitoring-4.1.1.json.txt](https://github.com/apache/trafficcontrol/files/6337471/monitoring-4.1.1.json.txt)
   - [A monitoring.json from master](https://github.com/apache/trafficcontrol/files/6337472/monitoring-master.json.txt) at 473d9c2422
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman commented on issue #5754: API v1 monitoring.json Profile Parameters no longer contain `health.threshold.*`

[GitBox <gi...@apache.org>]

zrhoffman commented on issue #5754:
URL: https://github.com/apache/trafficcontrol/issues/5754#issuecomment-822599403


   Adding *major* label since this prevents Traffic Monitor from offlining caches whose available bandwidth does not meet `health.threshold.availableBandwidthInKbps`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 closed issue #5754: API v1 monitoring.json Profile Parameters no longer contain `health.threshold.*`

[GitBox <gi...@apache.org>]

ocket8888 closed issue #5754:
URL: https://github.com/apache/trafficcontrol/issues/5754


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org