You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/10 01:37:56 UTC

[GitHub] [incubator-hudi] xushiyan opened a new pull request #1504: [HUDI-780] Add junit 5

xushiyan opened a new pull request #1504: [HUDI-780] Add junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504
 
 
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-613227516
 
 
   @prashantwason yeah seems like a good idea 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1504: [HUDI-780] Add junit 5

Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #1504: [HUDI-780] Add junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#discussion_r406563616
 
 

 ##########
 File path: hudi-client/src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java
 ##########
 @@ -22,22 +22,22 @@
 import org.apache.hudi.config.HoodieWriteConfig;
 
 import com.codahale.metrics.Timer;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 import java.util.Arrays;
 import java.util.Random;
 
 import static org.apache.hudi.metrics.Metrics.registerGauge;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 public class TestHoodieMetrics {
 
 Review comment:
   @yanghua @vinothchandar Some test classes do not have javadoc, while some others have. I think we'd better align on this just to standardize the codebase. If we agree that javadoc should be added to all test classes, then we'll fix them while making changes on those tests from now on. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on issue #1504: [HUDI-780] Add junit 5

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1504: [HUDI-780] Add junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612058285
 
 
   @yanghua @xushiyan my style has been to only use javadocs when it warrants them. forced writing of trivial/obvious docs is not very helpful.. That said, public APIs should have detailed/accurate javadocs, test framework/utility classes should. Not sure if we want to burn cycles (and increase file lengths) just for sake of having javadocs.. 
   
   I know this is subjective. but atleast goes with few books I have read in the past and what made sense to me.. We can also start a separate DISCUSS on this and defer.. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] yanghua commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612553230
 
 
   > > Constraint and standardization are conducive to the formation of good habits
   > 
   > @yanghua I am on the same page with this. My comment was more on how heavy our standards would be.. We can probably move this to the mailing list..
   
   agree

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] xushiyan commented on issue #1504: [HUDI-780] Add junit 5

Posted by GitBox <gi...@apache.org>.
xushiyan commented on issue #1504: [HUDI-780] Add junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612522614
 
 
   @vinothchandar @yanghua Ok in this PR i won't touch on javadocs...will do API changes only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] xushiyan commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
xushiyan commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-613549347
 
 
   @prashantwason Thank you! It's fixed. @yanghua @vinothchandar does the PR look good to merge?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] prashantwason commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
prashantwason commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-613071292
 
 
   Everything in the commit looks good so no reason coverage should be low. I checked the coverage report and it shows about 1000 lines missing coverage. 
   
   Since codecov has been flaky in the past (during merges, updates etc), I suggest forcing the commit again so codecov runs (maybe from the head or master). If it again reports low coverage, we can investigate.  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar merged pull request #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] xushiyan commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
xushiyan commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612666380
 
 
   > hi.. Wondering why codecov reports lower coverage? This will be a problem that we need to resolve early on.. thoughts?
   
   @vinothchandar tests converted to junit 5 were not reported by codecov... hence the decrease..not much clue atm

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report
   > Merging [#1504](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/5d717a28f45137bea71dffa31b0ae7ccbf1bda00&el=desc) will **decrease** coverage by `6.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1504/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1504      +/-   ##
   ============================================
   - Coverage     72.23%   65.31%   -6.92%     
   - Complexity      289     3142    +2853     
   ============================================
     Files           338      294      -44     
     Lines         15947    14402    -1545     
     Branches       1624     1454     -170     
   ============================================
   - Hits          11519     9407    -2112     
   - Misses         3700     4461     +761     
   + Partials        728      534     -194     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/hudi/keygen/KeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...main/java/org/apache/hudi/hive/HiveSyncConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY0NvbmZpZy5qYXZh) | `0.00% <0.00%> (-96.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/keygen/GlobalDeleteKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vR2xvYmFsRGVsZXRlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-90.48%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/hudi/keygen/SimpleKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vU2ltcGxlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (ø%)` | |
   | [...va/org/apache/hudi/keygen/ComplexKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vQ29tcGxleEtleUdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (-86.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/HoodieDataSourceHelpers.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVEYXRhU291cmNlSGVscGVycy5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/java/org/apache/hudi/hive/SchemaDifference.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9TY2hlbWFEaWZmZXJlbmNlLmphdmE=) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/metrics/InMemoryMetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9Jbk1lbW9yeU1ldHJpY3NSZXBvcnRlci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...c/main/java/org/apache/hudi/hive/HiveSyncTool.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY1Rvb2wuamF2YQ==) | `0.00% <0.00%> (-74.16%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [74 more](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=footer). Last update [5d717a2...4f7294b](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] yanghua commented on issue #1504: [HUDI-780] Add junit 5

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1504: [HUDI-780] Add junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612297922
 
 
   > @yanghua @xushiyan my style has been to only use javadocs when it warrants them. forced writing of trivial/obvious docs is not very helpful.. That said, public APIs should have detailed/accurate javadocs, test framework/utility classes should. Not sure if we want to burn cycles (and increase file lengths) just for sake of having javadocs..
   > 
   > I know this is subjective. but atleast goes with few books I have read in the past and what made sense to me.. We can also start a separate DISCUSS on this and defer..
   
   @vinothchandar  I think we all understand that sometimes class names or method names are inherently readable and they can be self-explanatory. Adding javadocs to some classes seems a bit redundant.
   
   My more consideration is: Constraint and standardization are conducive to the formation of good habits. Because the developers involved in the community are diverse. And many developers have a "lazy psychology", that is, without such constraints, they may rather not do it, not everyone has a good habit to think more. In fact, some test classes may be very simple and do not need to add a document description, but some classes may require, even some instructions and warnings.
   
   But once we do not enable tool inspection, many contributors will be reluctant to do this out of "lazy psychology". In order to enable tool inspection, then we must maintain the unity of the entire style. This is my practice in the Flink community.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] yanghua commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-613755671
 
 
   @xushiyan thanks for the update. I will take a look today.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1504: [HUDI-780] Add junit 5

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1504: [HUDI-780] Add junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#discussion_r406583034
 
 

 ##########
 File path: hudi-client/src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java
 ##########
 @@ -22,22 +22,22 @@
 import org.apache.hudi.config.HoodieWriteConfig;
 
 import com.codahale.metrics.Timer;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 import java.util.Arrays;
 import java.util.Random;
 
 import static org.apache.hudi.metrics.Metrics.registerGauge;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 public class TestHoodieMetrics {
 
 Review comment:
   I agree we'd better have javadocs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report
   > Merging [#1504](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/5d717a28f45137bea71dffa31b0ae7ccbf1bda00&el=desc) will **decrease** coverage by `6.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1504/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1504      +/-   ##
   ============================================
   - Coverage     72.23%   66.05%   -6.19%     
     Complexity      289      289              
   ============================================
     Files           338      338              
     Lines         15947    15947              
     Branches       1624     1624              
   ============================================
   - Hits          11519    10533     -986     
   - Misses         3700     4787    +1087     
   + Partials        728      627     -101     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/hudi/keygen/KeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...main/java/org/apache/hudi/hive/HiveSyncConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY0NvbmZpZy5qYXZh) | `0.00% <0.00%> (-96.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/keygen/GlobalDeleteKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vR2xvYmFsRGVsZXRlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-90.48%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/hudi/keygen/SimpleKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vU2ltcGxlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (ø%)` | |
   | [...va/org/apache/hudi/keygen/ComplexKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vQ29tcGxleEtleUdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (-86.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/HoodieDataSourceHelpers.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVEYXRhU291cmNlSGVscGVycy5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/java/org/apache/hudi/hive/SchemaDifference.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9TY2hlbWFEaWZmZXJlbmNlLmphdmE=) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/metrics/InMemoryMetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9Jbk1lbW9yeU1ldHJpY3NSZXBvcnRlci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...c/main/java/org/apache/hudi/hive/HiveSyncTool.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY1Rvb2wuamF2YQ==) | `0.00% <0.00%> (-74.16%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=footer). Last update [5d717a2...8b121d1](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report
   > Merging [#1504](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/a464a2972e83e648585277ebe567703c8285cf1e&el=desc) will **decrease** coverage by `6.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1504/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1504      +/-   ##
   ============================================
   - Coverage     72.20%   65.31%   -6.89%     
   - Complexity      289     3142    +2853     
   ============================================
     Files           338      294      -44     
     Lines         15946    14402    -1544     
     Branches       1624     1454     -170     
   ============================================
   - Hits          11514     9407    -2107     
   - Misses         3704     4461     +757     
   + Partials        728      534     -194     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/hudi/keygen/KeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...main/java/org/apache/hudi/hive/HiveSyncConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY0NvbmZpZy5qYXZh) | `0.00% <0.00%> (-96.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/keygen/GlobalDeleteKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vR2xvYmFsRGVsZXRlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-90.48%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/hudi/keygen/SimpleKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vU2ltcGxlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (ø%)` | |
   | [...va/org/apache/hudi/keygen/ComplexKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vQ29tcGxleEtleUdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (-86.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/HoodieDataSourceHelpers.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVEYXRhU291cmNlSGVscGVycy5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/java/org/apache/hudi/hive/SchemaDifference.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9TY2hlbWFEaWZmZXJlbmNlLmphdmE=) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (ø%)` | |
   | [...c/main/java/org/apache/hudi/hive/HiveSyncTool.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY1Rvb2wuamF2YQ==) | `0.00% <0.00%> (-74.16%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/scala/org/apache/hudi/IncrementalRelation.scala](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2h1ZGkvSW5jcmVtZW50YWxSZWxhdGlvbi5zY2FsYQ==) | `0.00% <0.00%> (-72.59%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [74 more](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=footer). Last update [a464a29...0891dd0](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report
   > Merging [#1504](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/644c1cc8bd1965271c4433edccb17aa8fda5f403&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1504/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1504      +/-   ##
   ============================================
   + Coverage     72.17%   72.20%   +0.02%     
     Complexity      289      289              
   ============================================
     Files           372      372              
     Lines         16267    16267              
     Branches       1637     1637              
   ============================================
   + Hits          11741    11745       +4     
   + Misses         3791     3787       -4     
     Partials        735      735              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ache/hudi/common/fs/inline/InMemoryFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL2lubGluZS9Jbk1lbW9yeUZpbGVTeXN0ZW0uamF2YQ==) | `79.31% <0.00%> (-10.35%)` | `0.00% <0.00%> (ø%)` | |
   | [...src/main/java/org/apache/hudi/metrics/Metrics.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `72.22% <0.00%> (+13.88%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/metrics/InMemoryMetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9Jbk1lbW9yeU1ldHJpY3NSZXBvcnRlci5qYXZh) | `80.00% <0.00%> (+40.00%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=footer). Last update [644c1cc...1168aac](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report
   > Merging [#1504](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/a464a2972e83e648585277ebe567703c8285cf1e&el=desc) will **decrease** coverage by `6.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1504/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1504      +/-   ##
   ============================================
   - Coverage     72.20%   65.94%   -6.26%     
   + Complexity      289      283       -6     
   ============================================
     Files           338      338              
     Lines         15946    15946              
     Branches       1624     1624              
   ============================================
   - Hits          11514    10516     -998     
   - Misses         3704     4805    +1101     
   + Partials        728      625     -103     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/hudi/keygen/KeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...main/java/org/apache/hudi/hive/HiveSyncConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY0NvbmZpZy5qYXZh) | `0.00% <0.00%> (-96.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/keygen/GlobalDeleteKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vR2xvYmFsRGVsZXRlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-90.48%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/hudi/keygen/SimpleKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vU2ltcGxlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (ø%)` | |
   | [...va/org/apache/hudi/keygen/ComplexKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vQ29tcGxleEtleUdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (-86.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/HoodieDataSourceHelpers.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVEYXRhU291cmNlSGVscGVycy5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/java/org/apache/hudi/hive/SchemaDifference.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9TY2hlbWFEaWZmZXJlbmNlLmphdmE=) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (ø%)` | |
   | [...c/main/java/org/apache/hudi/hive/HiveSyncTool.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY1Rvb2wuamF2YQ==) | `0.00% <0.00%> (-74.16%)` | `0.00% <0.00%> (ø%)` | |
   | [...udi/utilities/transform/FlatteningTransformer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3RyYW5zZm9ybS9GbGF0dGVuaW5nVHJhbnNmb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-73.69%)` | `0.00% <0.00%> (-6.00%)` | |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=footer). Last update [a464a29...08b0c13](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612558040
 
 
   hi.. Wondering why codecov reports lower coverage? This will be a problem that we need to resolve early on..  thoughts? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report
   > Merging [#1504](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/a464a2972e83e648585277ebe567703c8285cf1e&el=desc) will **decrease** coverage by `6.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1504/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1504      +/-   ##
   ============================================
   - Coverage     72.20%   65.94%   -6.26%     
   + Complexity      289      283       -6     
   ============================================
     Files           338      338              
     Lines         15946    15946              
     Branches       1624     1624              
   ============================================
   - Hits          11514    10516     -998     
   - Misses         3704     4805    +1101     
   + Partials        728      625     -103     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/hudi/keygen/KeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...main/java/org/apache/hudi/hive/HiveSyncConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY0NvbmZpZy5qYXZh) | `0.00% <0.00%> (-96.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/keygen/GlobalDeleteKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vR2xvYmFsRGVsZXRlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-90.48%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/hudi/keygen/SimpleKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vU2ltcGxlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (ø%)` | |
   | [...va/org/apache/hudi/keygen/ComplexKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vQ29tcGxleEtleUdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (-86.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/HoodieDataSourceHelpers.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVEYXRhU291cmNlSGVscGVycy5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/java/org/apache/hudi/hive/SchemaDifference.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9TY2hlbWFEaWZmZXJlbmNlLmphdmE=) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (ø%)` | |
   | [...c/main/java/org/apache/hudi/hive/HiveSyncTool.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY1Rvb2wuamF2YQ==) | `0.00% <0.00%> (-74.16%)` | `0.00% <0.00%> (ø%)` | |
   | [...udi/utilities/transform/FlatteningTransformer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3RyYW5zZm9ybS9GbGF0dGVuaW5nVHJhbnNmb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-73.69%)` | `0.00% <0.00%> (-6.00%)` | |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=footer). Last update [a464a29...08b0c13](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on issue #1504: [HUDI-780] Add junit 5

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1504: [HUDI-780] Add junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612521964
 
 
   > Constraint and standardization are conducive to the formation of good habits
   
   @yanghua I am on the same page with this. My comment was more on how heavy our standards  would be.. We can probably move this to the mailing list.. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] xushiyan commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
xushiyan commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-613241906
 
 
   @prashantwason Thanks for checking the report. I updated the branch, and as before, the report omitted the test cases covered by JUnit 5, resulting in coverage decrease. I've created https://jira.apache.org/jira/browse/HUDI-792 for investigation. @vinothchandar Let me check with the community for help 😄 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] prashantwason commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
prashantwason commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-613294181
 
 
   I may have found the reason for lower code coverage. 
   
   maven-surefire-plugin does not support JUnit 5 tests until version 2.22.0 and pom.xml is using version 2.19.1. So in essence, none of the unit tests converted to JUnit 5 ran therefore lowering the code coverage. I also verified this by looking at the CI logs and they dont have the tests that you have modified in this commit.
   
   https://stackoverflow.com/questions/36970384/surefire-is-not-picking-up-junit-5-tests
   https://dzone.com/articles/why-your-junit-5-tests-are-not-running-under-maven

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report
   > Merging [#1504](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/661b0b3bab85c8fd958a9e256dab99790ea92713&el=desc) will **decrease** coverage by `6.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1504/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1504      +/-   ##
   ============================================
   - Coverage     72.20%   66.13%   -6.07%     
     Complexity      289      289              
   ============================================
     Files           372      372              
     Lines         16267    16267              
     Branches       1637     1637              
   ============================================
   - Hits          11745    10758     -987     
   - Misses         3787     4876    +1089     
   + Partials        735      633     -102     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/hudi/keygen/KeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...main/java/org/apache/hudi/hive/HiveSyncConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY0NvbmZpZy5qYXZh) | `0.00% <0.00%> (-96.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/keygen/GlobalDeleteKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vR2xvYmFsRGVsZXRlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-90.48%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/hudi/keygen/SimpleKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vU2ltcGxlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (ø%)` | |
   | [...va/org/apache/hudi/keygen/ComplexKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vQ29tcGxleEtleUdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (-86.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/HoodieDataSourceHelpers.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVEYXRhU291cmNlSGVscGVycy5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/java/org/apache/hudi/hive/SchemaDifference.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9TY2hlbWFEaWZmZXJlbmNlLmphdmE=) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/metrics/InMemoryMetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9Jbk1lbW9yeU1ldHJpY3NSZXBvcnRlci5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...c/main/java/org/apache/hudi/hive/HiveSyncTool.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY1Rvb2wuamF2YQ==) | `0.00% <0.00%> (-74.16%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [30 more](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=footer). Last update [661b0b3...3970038](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612546623
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=h1) Report
   > Merging [#1504](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/a464a2972e83e648585277ebe567703c8285cf1e&el=desc) will **decrease** coverage by `6.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1504/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1504      +/-   ##
   ============================================
   - Coverage     72.20%   65.94%   -6.26%     
   + Complexity      289      283       -6     
   ============================================
     Files           338      338              
     Lines         15946    15946              
     Branches       1624     1624              
   ============================================
   - Hits          11514    10516     -998     
   - Misses         3704     4805    +1101     
   + Partials        728      625     -103     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/hudi/keygen/KeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...main/java/org/apache/hudi/hive/HiveSyncConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY0NvbmZpZy5qYXZh) | `0.00% <0.00%> (-96.30%)` | `0.00% <0.00%> (ø%)` | |
   | [...g/apache/hudi/keygen/GlobalDeleteKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vR2xvYmFsRGVsZXRlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-90.48%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/hudi/keygen/SimpleKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vU2ltcGxlS2V5R2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (-88.24%)` | `0.00% <0.00%> (ø%)` | |
   | [...va/org/apache/hudi/keygen/ComplexKeyGenerator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9rZXlnZW4vQ29tcGxleEtleUdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (-86.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/hudi/HoodieDataSourceHelpers.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS9Ib29kaWVEYXRhU291cmNlSGVscGVycy5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...in/java/org/apache/hudi/hive/SchemaDifference.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9TY2hlbWFEaWZmZXJlbmNlLmphdmE=) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (ø%)` | |
   | [...c/main/java/org/apache/hudi/hive/HiveSyncTool.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS1oaXZlLXN5bmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGl2ZS9IaXZlU3luY1Rvb2wuamF2YQ==) | `0.00% <0.00%> (-74.16%)` | `0.00% <0.00%> (ø%)` | |
   | [...udi/utilities/transform/FlatteningTransformer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3RyYW5zZm9ybS9GbGF0dGVuaW5nVHJhbnNmb3JtZXIuamF2YQ==) | `0.00% <0.00%> (-73.69%)` | `0.00% <0.00%> (-6.00%)` | |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-hudi/pull/1504/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=footer). Last update [a464a29...08b0c13](https://codecov.io/gh/apache/incubator-hudi/pull/1504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] xushiyan edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5

Posted by GitBox <gi...@apache.org>.
xushiyan edited a comment on issue #1504: [HUDI-780] Migrate test cases to Junit 5
URL: https://github.com/apache/incubator-hudi/pull/1504#issuecomment-612666380
 
 
   > hi.. Wondering why codecov reports lower coverage? This will be a problem that we need to resolve early on.. thoughts?
   
   @vinothchandar tests converted to junit 5 were not reported by codecov... hence the decrease..not much clue atm
   
   Hi @prashantwason noticed that you've configured the codecov, wonder if you could give some hints on the issue here? Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services