[GitHub] jgao54 closed pull request #4480: [AIRFLOW-3671] Remove MongoToS3Operator argument "replace" from kwargs

[GitBox <gi...@apache.org>]

jgao54 closed pull request #4480: [AIRFLOW-3671] Remove MongoToS3Operator argument "replace" from kwargs
URL: https://github.com/apache/airflow/pull/4480
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/airflow/contrib/operators/mongo_to_s3.py b/airflow/contrib/operators/mongo_to_s3.py
index 8bfa7a52f8..7d9785a2f6 100644
--- a/airflow/contrib/operators/mongo_to_s3.py
+++ b/airflow/contrib/operators/mongo_to_s3.py
@@ -42,6 +42,7 @@ def __init__(self,
                  s3_bucket,
                  s3_key,
                  mongo_db=None,
+                 replace=False,
                  *args, **kwargs):
         super(MongoToS3Operator, self).__init__(*args, **kwargs)
         # Conn Ids
@@ -58,9 +59,7 @@ def __init__(self,
         # S3 Settings
         self.s3_bucket = s3_bucket
         self.s3_key = s3_key
-
-        # KWARGS
-        self.replace = kwargs.pop('replace', False)
+        self.replace = replace
 
     def execute(self, context):
         """


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services