You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/12 11:55:13 UTC

[GitHub] [skywalking-data-collect-protocol] xu1009 commented on a change in pull request #59: Support ZGC add normal gc phrase

xu1009 commented on a change in pull request #59:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/59#discussion_r783006452



##########
File path: language-agent/JVMMetric.proto
##########
@@ -83,6 +83,7 @@ message GC {
 enum GCPhrase {
     NEW = 0;
     OLD = 1;
+    NORMAL = 2;

Review comment:
       where should i comment，near this code 
   
   like 
    NEW = 0;
       OLD = 1;
       NORMAL = 2;  // comments




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org