[jira] [Commented] (NIFI-4936) NiFi parent pom dependency management forcing versions to align defeating classloader isolation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387297#comment-16387297 ] 

ASF GitHub Bot commented on NIFI-4936:
--------------------------------------

GitHub user joewitt opened a pull request:

    https://github.com/apache/nifi/pull/2512

    NIFI-4936 pushed down version declarations to lowest appropriate level

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joewitt/incubator-nifi NIFI-4936

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2512.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2512
    
----
commit 2029a04d75b8fc14fef5e6d2f2c49fc56d70cde2
Author: joewitt <jo...@...>
Date:   2018-03-06T04:53:36Z

    NIFI-4936 pushed down version declarations to lowest appropriate level

----


> NiFi parent pom dependency management forcing versions to align defeating classloader isolation
> -----------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4936
>                 URL: https://issues.apache.org/jira/browse/NIFI-4936
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework, Extensions, Tools and Build
>    Affects Versions: 1.1.0, 1.2.0, 1.0.1, 1.3.0, 1.4.0, 1.5.0
>            Reporter: Joseph Witt
>            Assignee: Joseph Witt
>            Priority: Major
>             Fix For: 1.6.0
>
>         Attachments: NIFI-4936.patch, build-fixing, old-vs-new-dependencies.txt
>
>
> the top level pom in nifi has a massive dependency management section.  this was used initially to help enforce consistent usage of dependencies across nifi but this also can defeat the purpose of the classloader isolation offered by nars.  We need to push down dependency version declarations to the nar levels where appropriate.
> there have been reported issues of defects happening due to us using much newer versions (or sometimes older) of dependencies due to this dependency management model.  By pushing declarations down to the proper scope each nar/etc.. can use the specific versions of components it needs and we'll stop introducing issues by forcing a different version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)