You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "D.J. Heap" <dj...@gmail.com> on 2005/09/04 17:50:16 UTC
Re: svn trunk r16039: FAIL (win32 ra_local)
It appears some non-compliant code has crept into in wrapper_template.h:
d:\svnbuild\src-trunk\subversion\libsvn_ra_svn\../libsvn_ra/wrapper_template.h(62)
: error C2275: 'svn_ra_callbacks2_t' : illegal use of this type as an
expression
The variable is not being declared at the top of the scope and MSVC, at
least, is not happy about it.
DJ
Re: svn trunk r16039: FAIL (win32 ra_local)
Posted by Philip Martin <ph...@codematters.co.uk>.
David Anderson <da...@calixo.net> writes:
> D.J. Heap wrote:
>> The variable is not being declared at the top of the scope and MSVC,
>> at least, is not happy about it.
>
> Declaring variables anywhere in a scope is valid C99.
Subversion currently tries to avoid features new to C99 since not all
compilers support them. If you are using a recent version of gcc then
the option -Wdeclaration-after-statement will cause a warning for this
particular case.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r16039: FAIL (win32 ra_local)
Posted by "D.J. Heap" <dj...@gmail.com>.
On 9/4/05, David Anderson <da...@calixo.net> wrote:
>
> D.J. Heap wrote:
> > The variable is not being declared at the top of the scope and MSVC, at
> > least, is not happy about it.
>
> Declaring variables anywhere in a scope is valid C99. Does MSVC even
> support the revised standard?
>
> Regardless, this is an oversight on my part (I commited the code), and
> can be fixed quite painlessly. Hang on.
>
> - Dave.
>
Newer versions might, I'm not sure...but I believe we're trying to support
compilers which do not (older versions of GCC and VC) since it is not
difficult.
DJ
Re: svn trunk r16039: FAIL (win32 ra_local)
Posted by John Szakmeister <jo...@szakmeister.net>.
On Sunday 04 September 2005 14:00, David Anderson wrote:
> D.J. Heap wrote:
> > The variable is not being declared at the top of the scope and MSVC, at
> > least, is not happy about it.
>
> Declaring variables anywhere in a scope is valid C99. Does MSVC even
> support the revised standard?
MSVC 6.0 does not, and I believe that is what's used to build Apache2 and
Python 2.3, and as a result, the Subversion Win32 binaries (so that the C
runtimes all match when used together).
I believe the .NET and higher ones do have some C99 support, although I'm not
sure if it's complete support for it (I have a vague recollection of varargs
support in macros being unavailable).
> Regardless, this is an oversight on my part (I commited the code), and
> can be fixed quite painlessly. Hang on.
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r16039: FAIL (win32 ra_local)
Posted by David Anderson <da...@calixo.net>.
D.J. Heap wrote:
> The variable is not being declared at the top of the scope and MSVC, at
> least, is not happy about it.
Declaring variables anywhere in a scope is valid C99. Does MSVC even
support the revised standard?
Regardless, this is an oversight on my part (I commited the code), and
can be fixed quite painlessly. Hang on.
- Dave.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org