You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2022/09/15 13:41:45 UTC

[superset] branch revising-table-bar-chart-css updated: Changing content/bar load order

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch revising-table-bar-chart-css
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/revising-table-bar-chart-css by this push:
     new 9d1b912800 Changing content/bar load order
9d1b912800 is described below

commit 9d1b912800d246fa37e529d65d2999bfc3c3dc39
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Thu Sep 15 07:41:37 2022 -0600

    Changing content/bar load order
---
 .../plugins/plugin-chart-table/src/TableChart.tsx      | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
index 92f24a2b36..11c10bab28 100644
--- a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
+++ b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
@@ -491,6 +491,15 @@ export default function TableChart<D extends DataRecord = DataRecord>(
           // render `Cell`. This saves some time for large tables.
           return (
             <StyledCell {...cellProps}>
+              {valueRange && (
+                <div
+                  className={cx(
+                    'cell-bar',
+                    value && value < 0 ? 'negative' : 'positive',
+                  )}
+                  css={cellBarStyles}
+                />
+              )}
               {truncateLongCells ? (
                 <div
                   className="dt-truncate-cell"
@@ -501,15 +510,6 @@ export default function TableChart<D extends DataRecord = DataRecord>(
               ) : (
                 text
               )}
-              {valueRange && (
-                <div
-                  className={cx(
-                    'cell-bar',
-                    value && value < 0 ? 'negative' : 'positive',
-                  )}
-                  css={cellBarStyles}
-                />
-              )}
             </StyledCell>
           );
         },