You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sina Siadat (Jira)" <ji...@apache.org> on 2022/01/05 13:01:00 UTC
[jira] [Created] (CASSANDRA-17238) Constants$Literal.getText does not escape ' chars
Sina Siadat created CASSANDRA-17238:
---------------------------------------
Summary: Constants$Literal.getText does not escape ' chars
Key: CASSANDRA-17238
URL: https://issues.apache.org/jira/browse/CASSANDRA-17238
Project: Cassandra
Issue Type: Bug
Components: CQL/Semantics
Reporter: Sina Siadat
The [current implementation|https://sourcegraph.com/github.com/apache/cassandra@b83d722b99de79d131f58512564b901b11907182/-/blob/src/java/org/apache/cassandra/cql3/Constants.java?L358-361] is only adding single quotes around the text:
{code:java}
public String getText()
{
return type == Type.STRING ? String.format("'%s'", text) : text;
}
{code}
Something like this is necessary (I'm not sure if we need to do anything with the newline characters):
{code:java}
public String getText()
{
return type == Type.STRING ? String.format("'%s'", StringUtils.replace(text, "'", "''")) : text;
}
{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org