You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "OpenSocial QA Team (JIRA)" <ji...@apache.org> on 2008/01/18 02:35:34 UTC

[jira] Created: (SHINDIG-18) Dependent javascript libraries are not being passed in http-get "libs=" parameter

Dependent javascript libraries are not being passed in http-get "libs=" parameter
---------------------------------------------------------------------------------

                 Key: SHINDIG-18
                 URL: https://issues.apache.org/jira/browse/SHINDIG-18
             Project: Shindig
          Issue Type: Bug
         Environment: Url content type gadget loaded on Shindig container (current build)
            Reporter: OpenSocial QA Team


To reproduce the bug:
- Create a url content type gadget.
- Add Request feature="setprefs" to the gadget
- Check the url parameters passed and you will see that the container is passing only the setprefs.js as "libs=" parameter.
It should also include the tree of dependent javascript libraries as libs= parameters of the http-get request

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (SHINDIG-18) Dependent javascript libraries are not being passed in http-get "libs=" parameter

Posted by Bruno Bowden <br...@google.com>.
Hi "OpenSocial QA Team",

would you mind introducing yourself / yourselves?

[jira] Resolved: (SHINDIG-18) Dependent javascript libraries are not being passed in http-get "libs=" parameter

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Brown resolved SHINDIG-18.
--------------------------------

    Resolution: Invalid
      Assignee: John Hjelmstad

> Dependent javascript libraries are not being passed in http-get "libs=" parameter
> ---------------------------------------------------------------------------------
>
>                 Key: SHINDIG-18
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-18
>             Project: Shindig
>          Issue Type: Bug
>         Environment: Url content type gadget loaded on Shindig container (current build)
>            Reporter: OpenSocial QA Team
>            Assignee: John Hjelmstad
>
> To reproduce the bug:
> - Create a url content type gadget.
> - Add Request feature="setprefs" to the gadget
> - Check the url parameters passed and you will see that the container is passing only the setprefs.js as "libs=" parameter.
> It should also include the tree of dependent javascript libraries as libs= parameters of the http-get request

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-18) Dependent javascript libraries are not being passed in http-get "libs=" parameter

Posted by "OpenSocial QA Team (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560537#action_12560537 ] 

OpenSocial QA Team commented on SHINDIG-18:
-------------------------------------------

We've talked to John about this issue.  He said he will fix it.  Please check with him for more info.

> Dependent javascript libraries are not being passed in http-get "libs=" parameter
> ---------------------------------------------------------------------------------
>
>                 Key: SHINDIG-18
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-18
>             Project: Shindig
>          Issue Type: Bug
>         Environment: Url content type gadget loaded on Shindig container (current build)
>            Reporter: OpenSocial QA Team
>
> To reproduce the bug:
> - Create a url content type gadget.
> - Add Request feature="setprefs" to the gadget
> - Check the url parameters passed and you will see that the container is passing only the setprefs.js as "libs=" parameter.
> It should also include the tree of dependent javascript libraries as libs= parameters of the http-get request

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SHINDIG-18) Dependent javascript libraries are not being passed in http-get "libs=" parameter

Posted by "OpenSocial QA Team (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

OpenSocial QA Team closed SHINDIG-18.
-------------------------------------


Sorry about the confusion, but the Google Gadgets documentation (http://code.google.com/apis/gadgets/docs/fundamentals.html#URL) says "The core library is always passed in the URL for type="url" gadgets". 
That's why we thought this was a bug. Now its clear for us that this is just a difference in the implementation between igoogle and shindig containers.


> Dependent javascript libraries are not being passed in http-get "libs=" parameter
> ---------------------------------------------------------------------------------
>
>                 Key: SHINDIG-18
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-18
>             Project: Shindig
>          Issue Type: Bug
>         Environment: Url content type gadget loaded on Shindig container (current build)
>            Reporter: OpenSocial QA Team
>            Assignee: John Hjelmstad
>
> To reproduce the bug:
> - Create a url content type gadget.
> - Add Request feature="setprefs" to the gadget
> - Check the url parameters passed and you will see that the container is passing only the setprefs.js as "libs=" parameter.
> It should also include the tree of dependent javascript libraries as libs= parameters of the http-get request

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-18) Dependent javascript libraries are not being passed in http-get "libs=" parameter

Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560634#action_12560634 ] 

John Hjelmstad commented on SHINDIG-18:
---------------------------------------

What Kevin says is right - there was a bit of confusion in commmunication here. The setprefs.js lib will be packaged by the JavaScript servlet in Shindig with all its dependencies included. They need not be listed in the list of libs. In fact ,this is the proverbial feature, not a bug, in that this approach consolidates all JS serving in a single file rather than requiring several HTTP requests, one per feature bundle.

My understanding was that you found type=url gadget functionality to simply not be working. Is that true? If so, could you give any more details on the behavior you observed? That's what I'm signed up to fix :)

> Dependent javascript libraries are not being passed in http-get "libs=" parameter
> ---------------------------------------------------------------------------------
>
>                 Key: SHINDIG-18
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-18
>             Project: Shindig
>          Issue Type: Bug
>         Environment: Url content type gadget loaded on Shindig container (current build)
>            Reporter: OpenSocial QA Team
>
> To reproduce the bug:
> - Create a url content type gadget.
> - Add Request feature="setprefs" to the gadget
> - Check the url parameters passed and you will see that the container is passing only the setprefs.js as "libs=" parameter.
> It should also include the tree of dependent javascript libraries as libs= parameters of the http-get request

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-18) Dependent javascript libraries are not being passed in http-get "libs=" parameter

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560196#action_12560196 ] 

Kevin Brown commented on SHINDIG-18:
------------------------------------

This is incorrect. Only the features that the gadget author has explicitly requested are to be included in the libs parameter. Any conforming implementation that serves the javascript referenced by the libs parameter MUST also include any code required to satisfy that dependency as well as all core features (io, prefs, etc.)



> Dependent javascript libraries are not being passed in http-get "libs=" parameter
> ---------------------------------------------------------------------------------
>
>                 Key: SHINDIG-18
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-18
>             Project: Shindig
>          Issue Type: Bug
>         Environment: Url content type gadget loaded on Shindig container (current build)
>            Reporter: OpenSocial QA Team
>
> To reproduce the bug:
> - Create a url content type gadget.
> - Add Request feature="setprefs" to the gadget
> - Check the url parameters passed and you will see that the container is passing only the setprefs.js as "libs=" parameter.
> It should also include the tree of dependent javascript libraries as libs= parameters of the http-get request

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.