You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2018/06/20 21:29:25 UTC
Review Request 67678: when indicating a routed link has been detached
due to loss of connection,
set close flag based on ability of terminus to survive disconnection
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67678/
-----------------------------------------------------------
Review request for qpid and Ted Ross.
Bugs: DISPATCH-1020
https://issues.apache.org/jira/browse/DISPATCH-1020
Repository: qpid-dispatch
Description
-------
This ensures that the broker (or other route container) will clean-up the terminus state when the client is disconnected, unless that state is supposed to survive disconnection.
This is an alternative approach to solving DISPATCH-1020 to https://reviews.apache.org/r/67661/
Diffs
-----
src/router_core/connections.c 5fdc3bf
src/router_core/router_core_private.h cd2ffa4
Diff: https://reviews.apache.org/r/67678/diff/1/
Testing
-------
Thanks,
Gordon Sim
Re: Review Request 67678: when indicating a routed link has been
detached due to loss of connection,
set close flag based on ability of terminus to survive disconnection
Posted by Keith Wall <ke...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67678/#review205155
-----------------------------------------------------------
Looks good to me.
- Keith Wall
On June 20, 2018, 9:29 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67678/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 9:29 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Bugs: DISPATCH-1020
> https://issues.apache.org/jira/browse/DISPATCH-1020
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This ensures that the broker (or other route container) will clean-up the terminus state when the client is disconnected, unless that state is supposed to survive disconnection.
>
> This is an alternative approach to solving DISPATCH-1020 to https://reviews.apache.org/r/67661/
>
>
> Diffs
> -----
>
> src/router_core/connections.c 5fdc3bf
> src/router_core/router_core_private.h cd2ffa4
>
>
> Diff: https://reviews.apache.org/r/67678/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>