You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/11/28 08:50:53 UTC
[PR] [SPARK-32407][SPARK-35375][FOLLOWUP] Delete remaining comments on `Sphinx` and `Jinja2` [spark]
itholic opened a new pull request, #44052:
URL: https://github.com/apache/spark/pull/44052
### What changes were proposed in this pull request?
This is followup for https://github.com/apache/spark/pull/44046 to remove remaining comments.
### Why are the changes needed?
We don't need those comments anymore since it's fixed.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
The existing CI should pass
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-32407][SPARK-35375][FOLLOWUP] Delete remaining comments on `Sphinx` and `Jinja2` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44052:
URL: https://github.com/apache/spark/pull/44052#issuecomment-1829533485
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-32407][SPARK-35375][FOLLOWUP] Delete remaining comments on `Sphinx` and `Jinja2` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44052: [SPARK-32407][SPARK-35375][FOLLOWUP] Delete remaining comments on `Sphinx` and `Jinja2`
URL: https://github.com/apache/spark/pull/44052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-32407][SPARK-35375][FOLLOWUP] Delete remaining comments on `Sphinx` and `Jinja2` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44052:
URL: https://github.com/apache/spark/pull/44052#issuecomment-1829397431
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org