You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/29 19:16:31 UTC

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #19016: MXNet Extensions enhancements2

marcoabreu commented on a change in pull request #19016:
URL: https://github.com/apache/incubator-mxnet/pull/19016#discussion_r479680911



##########
File path: src/initialize.cc
##########
@@ -97,9 +97,7 @@ LibraryInitializer::LibraryInitializer()
   install_pthread_atfork_handlers();
 }
 
-LibraryInitializer::~LibraryInitializer() {
-  close_open_libs();
-}
+LibraryInitializer::~LibraryInitializer() = default;

Review comment:
       Can we add an assertion which checks if all handles have been closed during shutdown of mxnet? That could allow to catch a possible leak.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org