You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Markus Weimer <ma...@weimo.de> on 2015/08/26 21:03:11 UTC
Test failures in REEF.NET
Hi,
while reviewing pull requests this morning, I realized that several
tests fail in `master` on the .NET side.
The following ones fail with the same exception:
O.A.R.Tang.Tests.Format.TestConfigurationModule.SmokeTestConfig
O.A.R.Evaluator.Tests.EvaluatorConfigurationsTests.TestEvaluatorConfigurationFile
O.A.R.REEF.Evaluator.Tests.EvaluatorConfigurationsTests.TestEvaluatorConfigurations
O.A.R.Evaluator.Tests.EvaluatorTests.CanInjectAndExecuteTask
The exception is:
> System.ApplicationException: Cannot deserialize the file:
> Evaluator.conf --->
> System.Runtime.Serialization.SerializationException: Synchronization
> marker defined in the header does not match the read one.
Two more tests fail with a different error message:
Org.Apache.REEF.Tang.Tests.ClassHierarchy.TestClassHierarchyRoundTrip.TestInt
and
Org.Apache.REEF.Tang.Tests.ClassHierarchy.TestClassHierarchyRoundTrip.TestNamedRepeatConstructorArgClasses
fail with:
> System.NullReferenceException: Object reference not set to an
> instance of an object.
Am I the only one seeing these failures?
Thanks,
Markus
RE: Test failures in REEF.NET
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
I got test failure after clean build. Somehow the evaluator.conf file was not updated. I have created a Jira REEF-652 and submitted the PR.
Thanks,
Julia
-----Original Message-----
From: Markus Weimer [mailto:markus@weimo.de]
Sent: Wednesday, August 26, 2015 3:23 PM
To: dev@reef.incubator.apache.org
Subject: Re: Test failures in REEF.NET
Julia, do the tests pass for you after a deep clean?
Markus
On 2015-08-26 15:08, Julia Wang (QIUHE) wrote:
> This config file is generated at run time rather than build time. It is the config file that Java driver created and submitted to C# evaluator at run time. The test is to simulate how evaluator read this file. It is a unit test.
>
> Well, we can change it to an e2e testing, grab the file on the fly and use it in testing. It is possible but not a simple unit test any more.
>
> This config file is part of the PR. Was it not updated at your folder after sync?
>
> -----Original Message-----
> From: Andrew Chung [mailto:afchung90@gmail.com]
> Sent: Wednesday, August 26, 2015 2:27 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: Test failures in REEF.NET
>
> Checking in configuration files seems kind of strange to me. We also check in a driver.conf for ASA, but it was only due to the fact that much of our dev/test machines don't have Java installed. REEF devs would have to have Java installed to build though. Is it possible to generate configurations in the build process for .NET? This would make Java and .NET changes more tightly coupled.
>
> Thanks,
> Andrew
>
> On Wed, Aug 26, 2015 at 1:42 PM, Markus Weimer <ma...@weimo.de> wrote:
>
>> On 2015-08-26 13:15, Andrew Chung wrote:
>>> I have tried it, but the problem seems to persist.
>>
>> Confirmed, the test failures persist even after deep cleaning.
>>
>>
>>> I've reverted the commits, cleaning the folders each time, and it
>>> would appear that REEF-620
>>> <https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
>>> sues.apache.org%2fjira%2fbrowse%2fREEF-620&data=01%7c01%7cQiuhe.Wang%40microsoft.com%7c1a974398edd443334df208d2ae5d31c3%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=u9%2fV%2bG4fR2imHxG5r2BpMOXAcN5ufpUQh6ubBvTgq9E%3d> was the delta that caused the failure.
>>
>> Ah, that change added a new `evaluator.conf` file, if I recall
>> correctly. That could be the root cause for the issue at hand.
>>
>> Markus
>>
Re: Test failures in REEF.NET
Posted by Markus Weimer <ma...@weimo.de>.
Julia, do the tests pass for you after a deep clean?
Markus
On 2015-08-26 15:08, Julia Wang (QIUHE) wrote:
> This config file is generated at run time rather than build time. It is the config file that Java driver created and submitted to C# evaluator at run time. The test is to simulate how evaluator read this file. It is a unit test.
>
> Well, we can change it to an e2e testing, grab the file on the fly and use it in testing. It is possible but not a simple unit test any more.
>
> This config file is part of the PR. Was it not updated at your folder after sync?
>
> -----Original Message-----
> From: Andrew Chung [mailto:afchung90@gmail.com]
> Sent: Wednesday, August 26, 2015 2:27 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: Test failures in REEF.NET
>
> Checking in configuration files seems kind of strange to me. We also check in a driver.conf for ASA, but it was only due to the fact that much of our dev/test machines don't have Java installed. REEF devs would have to have Java installed to build though. Is it possible to generate configurations in the build process for .NET? This would make Java and .NET changes more tightly coupled.
>
> Thanks,
> Andrew
>
> On Wed, Aug 26, 2015 at 1:42 PM, Markus Weimer <ma...@weimo.de> wrote:
>
>> On 2015-08-26 13:15, Andrew Chung wrote:
>>> I have tried it, but the problem seems to persist.
>>
>> Confirmed, the test failures persist even after deep cleaning.
>>
>>
>>> I've reverted the commits, cleaning the folders each time, and it
>>> would appear that REEF-620
>>> <https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
>>> sues.apache.org%2fjira%2fbrowse%2fREEF-620&data=01%7c01%7cQiuhe.Wang%40microsoft.com%7c1a974398edd443334df208d2ae5d31c3%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=u9%2fV%2bG4fR2imHxG5r2BpMOXAcN5ufpUQh6ubBvTgq9E%3d> was the delta that caused the failure.
>>
>> Ah, that change added a new `evaluator.conf` file, if I recall
>> correctly. That could be the root cause for the issue at hand.
>>
>> Markus
>>
RE: Test failures in REEF.NET
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
This config file is generated at run time rather than build time. It is the config file that Java driver created and submitted to C# evaluator at run time. The test is to simulate how evaluator read this file. It is a unit test.
Well, we can change it to an e2e testing, grab the file on the fly and use it in testing. It is possible but not a simple unit test any more.
This config file is part of the PR. Was it not updated at your folder after sync?
-----Original Message-----
From: Andrew Chung [mailto:afchung90@gmail.com]
Sent: Wednesday, August 26, 2015 2:27 PM
To: dev@reef.incubator.apache.org
Subject: Re: Test failures in REEF.NET
Checking in configuration files seems kind of strange to me. We also check in a driver.conf for ASA, but it was only due to the fact that much of our dev/test machines don't have Java installed. REEF devs would have to have Java installed to build though. Is it possible to generate configurations in the build process for .NET? This would make Java and .NET changes more tightly coupled.
Thanks,
Andrew
On Wed, Aug 26, 2015 at 1:42 PM, Markus Weimer <ma...@weimo.de> wrote:
> On 2015-08-26 13:15, Andrew Chung wrote:
> > I have tried it, but the problem seems to persist.
>
> Confirmed, the test failures persist even after deep cleaning.
>
>
> > I've reverted the commits, cleaning the folders each time, and it
> > would appear that REEF-620
> > <https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fis
> > sues.apache.org%2fjira%2fbrowse%2fREEF-620&data=01%7c01%7cQiuhe.Wang%40microsoft.com%7c1a974398edd443334df208d2ae5d31c3%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=u9%2fV%2bG4fR2imHxG5r2BpMOXAcN5ufpUQh6ubBvTgq9E%3d> was the delta that caused the failure.
>
> Ah, that change added a new `evaluator.conf` file, if I recall
> correctly. That could be the root cause for the issue at hand.
>
> Markus
>
Re: Test failures in REEF.NET
Posted by Andrew Chung <af...@gmail.com>.
Checking in configuration files seems kind of strange to me. We also check
in a driver.conf for ASA, but it was only due to the fact that much of our
dev/test machines don't have Java installed. REEF devs would have to have
Java installed to build though. Is it possible to generate configurations
in the build process for .NET? This would make Java and .NET changes more
tightly coupled.
Thanks,
Andrew
On Wed, Aug 26, 2015 at 1:42 PM, Markus Weimer <ma...@weimo.de> wrote:
> On 2015-08-26 13:15, Andrew Chung wrote:
> > I have tried it, but the problem seems to persist.
>
> Confirmed, the test failures persist even after deep cleaning.
>
>
> > I've reverted the commits, cleaning the folders each time, and it
> > would appear that REEF-620
> > <https://issues.apache.org/jira/browse/REEF-620> was the delta that
> > caused the failure.
>
> Ah, that change added a new `evaluator.conf` file, if I recall
> correctly. That could be the root cause for the issue at hand.
>
> Markus
>
Re: Test failures in REEF.NET
Posted by Markus Weimer <ma...@weimo.de>.
On 2015-08-26 13:15, Andrew Chung wrote:
> I have tried it, but the problem seems to persist.
Confirmed, the test failures persist even after deep cleaning.
> I've reverted the commits, cleaning the folders each time, and it
> would appear that REEF-620
> <https://issues.apache.org/jira/browse/REEF-620> was the delta that
> caused the failure.
Ah, that change added a new `evaluator.conf` file, if I recall
correctly. That could be the root cause for the issue at hand.
Markus
Re: Test failures in REEF.NET
Posted by Andrew Chung <af...@gmail.com>.
I have tried it, but the problem seems to persist. I've reverted the
commits, cleaning the folders each time, and it would appear that REEF-620
<https://issues.apache.org/jira/browse/REEF-620> was the delta that caused
the failure. Julia, would you happen to have a quick solution to fix?
Thanks,
Andrew
On Wed, Aug 26, 2015 at 1:12 PM, Julia Wang (QIUHE) <
Qiuhe.Wang@microsoft.com> wrote:
> Please do:
> mvn clean install
> remove lang\cs\bin folder
> then build again
>
> -----Original Message-----
> From: Andrew Chung [mailto:afchung90@gmail.com]
> Sent: Wednesday, August 26, 2015 12:46 PM
> To: dev@reef.incubator.apache.org
> Subject: Re: Test failures in REEF.NET
>
> Seeing these failures after syncing as well.
>
> Thanks,
> Andrew
>
> On Wed, Aug 26, 2015 at 12:03 PM, Markus Weimer <ma...@weimo.de> wrote:
>
> > Hi,
> >
> > while reviewing pull requests this morning, I realized that several
> > tests fail in `master` on the .NET side.
> >
> > The following ones fail with the same exception:
> >
> > O.A.R.Tang.Tests.Format.TestConfigurationModule.SmokeTestConfig
> >
> > O.A.R.Evaluator.Tests.EvaluatorConfigurationsTests.TestEvaluatorConfig
> > urationFile
> >
> > O.A.R.REEF.Evaluator.Tests.EvaluatorConfigurationsTests.TestEvaluatorC
> > onfigurations
> > O.A.R.Evaluator.Tests.EvaluatorTests.CanInjectAndExecuteTask
> >
> > The exception is:
> >
> > > System.ApplicationException: Cannot deserialize the file:
> > > Evaluator.conf --->
> > > System.Runtime.Serialization.SerializationException: Synchronization
> > > marker defined in the header does not match the read one.
> >
> > Two more tests fail with a different error message:
> >
> >
> > Org.Apache.REEF.Tang.Tests.ClassHierarchy.TestClassHierarchyRoundTrip.
> > TestInt
> >
> > and
> >
> >
> > Org.Apache.REEF.Tang.Tests.ClassHierarchy.TestClassHierarchyRoundTrip.
> > TestNamedRepeatConstructorArgClasses
> >
> >
> > fail with:
> >
> > > System.NullReferenceException: Object reference not set to an
> > > instance of an object.
> >
> > Am I the only one seeing these failures?
> >
> > Thanks,
> >
> > Markus
> >
> >
>
RE: Test failures in REEF.NET
Posted by "Julia Wang (QIUHE)" <Qi...@microsoft.com>.
Please do:
mvn clean install
remove lang\cs\bin folder
then build again
-----Original Message-----
From: Andrew Chung [mailto:afchung90@gmail.com]
Sent: Wednesday, August 26, 2015 12:46 PM
To: dev@reef.incubator.apache.org
Subject: Re: Test failures in REEF.NET
Seeing these failures after syncing as well.
Thanks,
Andrew
On Wed, Aug 26, 2015 at 12:03 PM, Markus Weimer <ma...@weimo.de> wrote:
> Hi,
>
> while reviewing pull requests this morning, I realized that several
> tests fail in `master` on the .NET side.
>
> The following ones fail with the same exception:
>
> O.A.R.Tang.Tests.Format.TestConfigurationModule.SmokeTestConfig
>
> O.A.R.Evaluator.Tests.EvaluatorConfigurationsTests.TestEvaluatorConfig
> urationFile
>
> O.A.R.REEF.Evaluator.Tests.EvaluatorConfigurationsTests.TestEvaluatorC
> onfigurations
> O.A.R.Evaluator.Tests.EvaluatorTests.CanInjectAndExecuteTask
>
> The exception is:
>
> > System.ApplicationException: Cannot deserialize the file:
> > Evaluator.conf --->
> > System.Runtime.Serialization.SerializationException: Synchronization
> > marker defined in the header does not match the read one.
>
> Two more tests fail with a different error message:
>
>
> Org.Apache.REEF.Tang.Tests.ClassHierarchy.TestClassHierarchyRoundTrip.
> TestInt
>
> and
>
>
> Org.Apache.REEF.Tang.Tests.ClassHierarchy.TestClassHierarchyRoundTrip.
> TestNamedRepeatConstructorArgClasses
>
>
> fail with:
>
> > System.NullReferenceException: Object reference not set to an
> > instance of an object.
>
> Am I the only one seeing these failures?
>
> Thanks,
>
> Markus
>
>
Re: Test failures in REEF.NET
Posted by Andrew Chung <af...@gmail.com>.
Seeing these failures after syncing as well.
Thanks,
Andrew
On Wed, Aug 26, 2015 at 12:03 PM, Markus Weimer <ma...@weimo.de> wrote:
> Hi,
>
> while reviewing pull requests this morning, I realized that several
> tests fail in `master` on the .NET side.
>
> The following ones fail with the same exception:
>
> O.A.R.Tang.Tests.Format.TestConfigurationModule.SmokeTestConfig
>
> O.A.R.Evaluator.Tests.EvaluatorConfigurationsTests.TestEvaluatorConfigurationFile
>
> O.A.R.REEF.Evaluator.Tests.EvaluatorConfigurationsTests.TestEvaluatorConfigurations
> O.A.R.Evaluator.Tests.EvaluatorTests.CanInjectAndExecuteTask
>
> The exception is:
>
> > System.ApplicationException: Cannot deserialize the file:
> > Evaluator.conf --->
> > System.Runtime.Serialization.SerializationException: Synchronization
> > marker defined in the header does not match the read one.
>
> Two more tests fail with a different error message:
>
>
> Org.Apache.REEF.Tang.Tests.ClassHierarchy.TestClassHierarchyRoundTrip.TestInt
>
> and
>
>
> Org.Apache.REEF.Tang.Tests.ClassHierarchy.TestClassHierarchyRoundTrip.TestNamedRepeatConstructorArgClasses
>
>
> fail with:
>
> > System.NullReferenceException: Object reference not set to an
> > instance of an object.
>
> Am I the only one seeing these failures?
>
> Thanks,
>
> Markus
>
>