[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4361: Fix NPE when there is no aggregation results in prettyPrintResponse

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #4361: Fix NPE when there is no aggregation results in prettyPrintResponse
URL: https://github.com/apache/incubator-pinot/pull/4361#discussion_r297006421
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/Quickstart.java
 ##########
 @@ -209,6 +212,35 @@ public void run() {
     printStatus(Color.GREEN, "You can always go to http://localhost:9000/query/ to play around in the query console");
   }
 
+  protected void waitForAllDocsLoaded(QuickstartRunner runner, long timeoutMs)
+      throws Exception {
+    final long countStarResult = 97889L;
+    TestUtils.waitForCondition(new Function<Void, Boolean>() {
 
 Review comment:
   TestUtils? better to use RetryPolicies in PinotCommon. It allows you to try every 5 seconds until 60 seconds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org