[GitHub] [flink] snuyanzin commented on a diff in pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin commented on code in PR #21993:
URL: https://github.com/apache/flink/pull/21993#discussion_r1116007389


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementArgumentTypeStrategy.java:
##########
@@ -31,24 +31,28 @@
 
 import java.util.Optional;
 
-import static org.apache.flink.table.types.logical.utils.LogicalTypeCasts.supportsImplicitCast;
-
 /** Specific {@link ArgumentTypeStrategy} for {@link BuiltInFunctionDefinitions#ARRAY_CONTAINS}. */
 @Internal
 class ArrayElementArgumentTypeStrategy implements ArgumentTypeStrategy {
 
+    private final boolean preserveNullability;
+
+    public ArrayElementArgumentTypeStrategy(boolean preserveNullability) {
+        this.preserveNullability = preserveNullability;
+    }
+
     @Override
     public Optional<DataType> inferArgumentType(
             CallContext callContext, int argumentPos, boolean throwOnFailure) {
         final ArrayType haystackType =
                 (ArrayType) callContext.getArgumentDataTypes().get(0).getLogicalType();
         final LogicalType haystackElementType = haystackType.getElementType();
-        final LogicalType needleType =
-                callContext.getArgumentDataTypes().get(argumentPos).getLogicalType();
-        if (supportsImplicitCast(needleType, haystackElementType)) {

Review Comment:
   I didn't get: check for implicit cast should be removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org