You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2018/06/18 20:59:35 UTC
Re: Review Request 66839: translation of remote address in link route
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/
-----------------------------------------------------------
(Updated June 18, 2018, 8:59 p.m.)
Review request for qpid and Ted Ross.
Changes
-------
This adds another option, delExternalPrefix, that can be used instead of or as well as addExternalPrefix.
Bugs: DISPATCH-980
https://issues.apache.org/jira/browse/DISPATCH-980
Repository: qpid-dispatch
Description (updated)
-------
This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
Diffs (updated)
-----
include/qpid/dispatch/router_core.h 8f144b0
python/qpid_dispatch/management/qdrouter.json 42f501f
src/router_config.c 94758df
src/router_core/agent_config_link_route.h 57f6f0d
src/router_core/agent_config_link_route.c 981d142
src/router_core/connections.c 5fdc3bf
src/router_core/forwarder.c fca19c3
src/router_core/route_control.h 3c715bc
src/router_core/route_control.c 61f426d
src/router_core/router_core.c 9d7f7a5
src/router_core/router_core_private.h cd2ffa4
src/router_core/terminus.c 4c0e0a3
tests/CMakeLists.txt 159521d
tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
Diff: https://reviews.apache.org/r/66839/diff/2/
Changes: https://reviews.apache.org/r/66839/diff/1-2/
Testing
-------
Added system tests plus some ad hoc testing.
Thanks,
Gordon Sim
Re: Review Request 66839: translation of remote address in link route
Posted by Gordon Sim <gs...@redhat.com>.
> On June 20, 2018, 1:37 p.m., Ganesh Murthy wrote:
> > tests/system_tests_link_routes_add_external_prefix.py
> > Lines 193 (patched)
> > <https://reviews.apache.org/r/66839/diff/3/?file=2042238#file2042238line193>
> >
> > error = "Incorrect message. Got %s, expected %s" % (event.message.body, self.message.body)
> >
> > must be changed to
> >
> > self.error = "Incorrect message. Got %s, expected %s" % (event.message.body, self.message.body)
Well spotted, thanks Ganesh! I have fixed that now (tests still pass ;-)
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/#review205070
-----------------------------------------------------------
On June 20, 2018, 2:08 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66839/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 2:08 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Bugs: DISPATCH-980
> https://issues.apache.org/jira/browse/DISPATCH-980
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
>
>
> Diffs
> -----
>
> include/qpid/dispatch/router_core.h 8f144b0
> python/qpid_dispatch/management/qdrouter.json 42f501f
> src/router_config.c 94758df
> src/router_core/agent_config_link_route.h 57f6f0d
> src/router_core/agent_config_link_route.c 981d142
> src/router_core/connections.c 5fdc3bf
> src/router_core/forwarder.c fca19c3
> src/router_core/route_control.h 3c715bc
> src/router_core/route_control.c 61f426d
> src/router_core/router_core.c 9d7f7a5
> src/router_core/router_core_private.h cd2ffa4
> src/router_core/terminus.c 4c0e0a3
> tests/CMakeLists.txt 159521d
> tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66839/diff/4/
>
>
> Testing
> -------
>
> Added system tests plus some ad hoc testing.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 66839: translation of remote address in link route
Posted by Ganesh Murthy <gm...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/#review205070
-----------------------------------------------------------
tests/system_tests_link_routes_add_external_prefix.py
Lines 193 (patched)
<https://reviews.apache.org/r/66839/#comment288025>
error = "Incorrect message. Got %s, expected %s" % (event.message.body, self.message.body)
must be changed to
self.error = "Incorrect message. Got %s, expected %s" % (event.message.body, self.message.body)
- Ganesh Murthy
On June 18, 2018, 9:37 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66839/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 9:37 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Bugs: DISPATCH-980
> https://issues.apache.org/jira/browse/DISPATCH-980
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
>
>
> Diffs
> -----
>
> include/qpid/dispatch/router_core.h 8f144b0
> python/qpid_dispatch/management/qdrouter.json 42f501f
> src/router_config.c 94758df
> src/router_core/agent_config_link_route.h 57f6f0d
> src/router_core/agent_config_link_route.c 981d142
> src/router_core/connections.c 5fdc3bf
> src/router_core/forwarder.c fca19c3
> src/router_core/route_control.h 3c715bc
> src/router_core/route_control.c 61f426d
> src/router_core/router_core.c 9d7f7a5
> src/router_core/router_core_private.h cd2ffa4
> src/router_core/terminus.c 4c0e0a3
> tests/CMakeLists.txt 159521d
> tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66839/diff/3/
>
>
> Testing
> -------
>
> Added system tests plus some ad hoc testing.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 66839: translation of remote address in link route
Posted by Gordon Sim <gs...@redhat.com>.
> On June 20, 2018, 2:22 p.m., Ganesh Murthy wrote:
> > 1. Should displayLinkRoutes() function in qpid-dispatch/tools/qdstat be modified to show "addExternalPrefix" and "delExternalPrefix" attributes?
> > 2. I think we should have an additional test added to system_tests_link_routes_add_external_prefix which will run qdmanage query on link routes and make sure that "addExternalPrefix" and "delExternalPrefix" are showing correctly
Done. (The extra columns do add a little noise to the qdstat output considering they will often not be set)
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/#review205080
-----------------------------------------------------------
On June 20, 2018, 4:25 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66839/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 4:25 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Bugs: DISPATCH-980
> https://issues.apache.org/jira/browse/DISPATCH-980
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
>
>
> Diffs
> -----
>
> include/qpid/dispatch/router_core.h 8f144b0
> python/qpid_dispatch/management/qdrouter.json 42f501f
> src/router_config.c 94758df
> src/router_core/agent_config_link_route.h 57f6f0d
> src/router_core/agent_config_link_route.c 981d142
> src/router_core/connections.c 5fdc3bf
> src/router_core/forwarder.c fca19c3
> src/router_core/route_control.h 3c715bc
> src/router_core/route_control.c 61f426d
> src/router_core/router_core.c 9d7f7a5
> src/router_core/router_core_private.h cd2ffa4
> src/router_core/terminus.c 4c0e0a3
> tests/CMakeLists.txt 159521d
> tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
> tools/qdstat 1e3a3a3
>
>
> Diff: https://reviews.apache.org/r/66839/diff/5/
>
>
> Testing
> -------
>
> Added system tests plus some ad hoc testing.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 66839: translation of remote address in link route
Posted by Ganesh Murthy <gm...@redhat.com>.
> On June 20, 2018, 2:22 p.m., Ganesh Murthy wrote:
> > 1. Should displayLinkRoutes() function in qpid-dispatch/tools/qdstat be modified to show "addExternalPrefix" and "delExternalPrefix" attributes?
> > 2. I think we should have an additional test added to system_tests_link_routes_add_external_prefix which will run qdmanage query on link routes and make sure that "addExternalPrefix" and "delExternalPrefix" are showing correctly
>
> Gordon Sim wrote:
> Done. (The extra columns do add a little noise to the qdstat output considering they will often not be set)
The qdstat test looks good. Can you also please add a qdmanage test (qdmanage query --type=linkroute) to make sure that the "addExternalPrefix" and "delExternalPrefix" columns are present.
- Ganesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/#review205080
-----------------------------------------------------------
On June 20, 2018, 4:25 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66839/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 4:25 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Bugs: DISPATCH-980
> https://issues.apache.org/jira/browse/DISPATCH-980
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
>
>
> Diffs
> -----
>
> include/qpid/dispatch/router_core.h 8f144b0
> python/qpid_dispatch/management/qdrouter.json 42f501f
> src/router_config.c 94758df
> src/router_core/agent_config_link_route.h 57f6f0d
> src/router_core/agent_config_link_route.c 981d142
> src/router_core/connections.c 5fdc3bf
> src/router_core/forwarder.c fca19c3
> src/router_core/route_control.h 3c715bc
> src/router_core/route_control.c 61f426d
> src/router_core/router_core.c 9d7f7a5
> src/router_core/router_core_private.h cd2ffa4
> src/router_core/terminus.c 4c0e0a3
> tests/CMakeLists.txt 159521d
> tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
> tools/qdstat 1e3a3a3
>
>
> Diff: https://reviews.apache.org/r/66839/diff/5/
>
>
> Testing
> -------
>
> Added system tests plus some ad hoc testing.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 66839: translation of remote address in link route
Posted by Gordon Sim <gs...@redhat.com>.
> On June 20, 2018, 2:22 p.m., Ganesh Murthy wrote:
> > 1. Should displayLinkRoutes() function in qpid-dispatch/tools/qdstat be modified to show "addExternalPrefix" and "delExternalPrefix" attributes?
> > 2. I think we should have an additional test added to system_tests_link_routes_add_external_prefix which will run qdmanage query on link routes and make sure that "addExternalPrefix" and "delExternalPrefix" are showing correctly
>
> Gordon Sim wrote:
> Done. (The extra columns do add a little noise to the qdstat output considering they will often not be set)
>
> Ganesh Murthy wrote:
> The qdstat test looks good. Can you also please add a qdmanage test (qdmanage query --type=linkroute) to make sure that the "addExternalPrefix" and "delExternalPrefix" columns are present.
Done!
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/#review205080
-----------------------------------------------------------
On June 21, 2018, 3:19 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66839/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 3:19 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Bugs: DISPATCH-980
> https://issues.apache.org/jira/browse/DISPATCH-980
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
>
>
> Diffs
> -----
>
> include/qpid/dispatch/router_core.h 8f144b0
> python/qpid_dispatch/management/qdrouter.json 42f501f
> src/router_config.c 94758df
> src/router_core/agent_config_link_route.h 57f6f0d
> src/router_core/agent_config_link_route.c 981d142
> src/router_core/connections.c 5fdc3bf
> src/router_core/forwarder.c fca19c3
> src/router_core/route_control.h 3c715bc
> src/router_core/route_control.c 61f426d
> src/router_core/router_core.c 9d7f7a5
> src/router_core/router_core_private.h cd2ffa4
> src/router_core/terminus.c 4c0e0a3
> tests/CMakeLists.txt 159521d
> tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
> tools/qdstat 1e3a3a3
>
>
> Diff: https://reviews.apache.org/r/66839/diff/6/
>
>
> Testing
> -------
>
> Added system tests plus some ad hoc testing.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 66839: translation of remote address in link route
Posted by Ganesh Murthy <gm...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/#review205080
-----------------------------------------------------------
1. Should displayLinkRoutes() function in qpid-dispatch/tools/qdstat be modified to show "addExternalPrefix" and "delExternalPrefix" attributes?
2. I think we should have an additional test added to system_tests_link_routes_add_external_prefix which will run qdmanage query on link routes and make sure that "addExternalPrefix" and "delExternalPrefix" are showing correctly
- Ganesh Murthy
On June 20, 2018, 2:08 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66839/
> -----------------------------------------------------------
>
> (Updated June 20, 2018, 2:08 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Bugs: DISPATCH-980
> https://issues.apache.org/jira/browse/DISPATCH-980
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
>
>
> Diffs
> -----
>
> include/qpid/dispatch/router_core.h 8f144b0
> python/qpid_dispatch/management/qdrouter.json 42f501f
> src/router_config.c 94758df
> src/router_core/agent_config_link_route.h 57f6f0d
> src/router_core/agent_config_link_route.c 981d142
> src/router_core/connections.c 5fdc3bf
> src/router_core/forwarder.c fca19c3
> src/router_core/route_control.h 3c715bc
> src/router_core/route_control.c 61f426d
> src/router_core/router_core.c 9d7f7a5
> src/router_core/router_core_private.h cd2ffa4
> src/router_core/terminus.c 4c0e0a3
> tests/CMakeLists.txt 159521d
> tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66839/diff/4/
>
>
> Testing
> -------
>
> Added system tests plus some ad hoc testing.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 66839: translation of remote address in link route
Posted by Ganesh Murthy <gm...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/#review205183
-----------------------------------------------------------
Ship it!
Ship It!
- Ganesh Murthy
On June 21, 2018, 3:19 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66839/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 3:19 p.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Bugs: DISPATCH-980
> https://issues.apache.org/jira/browse/DISPATCH-980
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
>
>
> Diffs
> -----
>
> include/qpid/dispatch/router_core.h 8f144b0
> python/qpid_dispatch/management/qdrouter.json 42f501f
> src/router_config.c 94758df
> src/router_core/agent_config_link_route.h 57f6f0d
> src/router_core/agent_config_link_route.c 981d142
> src/router_core/connections.c 5fdc3bf
> src/router_core/forwarder.c fca19c3
> src/router_core/route_control.h 3c715bc
> src/router_core/route_control.c 61f426d
> src/router_core/router_core.c 9d7f7a5
> src/router_core/router_core_private.h cd2ffa4
> src/router_core/terminus.c 4c0e0a3
> tests/CMakeLists.txt 159521d
> tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
> tools/qdstat 1e3a3a3
>
>
> Diff: https://reviews.apache.org/r/66839/diff/6/
>
>
> Testing
> -------
>
> Added system tests plus some ad hoc testing.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 66839: translation of remote address in link route
Posted by Ted Ross <tr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/#review205460
-----------------------------------------------------------
Ship it!
Ship It!
- Ted Ross
On June 21, 2018, 11:19 a.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66839/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 11:19 a.m.)
>
>
> Review request for qpid and Ted Ross.
>
>
> Bugs: DISPATCH-980
> https://issues.apache.org/jira/browse/DISPATCH-980
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
>
>
> Diffs
> -----
>
> include/qpid/dispatch/router_core.h 8f144b0
> python/qpid_dispatch/management/qdrouter.json 42f501f
> src/router_config.c 94758df
> src/router_core/agent_config_link_route.h 57f6f0d
> src/router_core/agent_config_link_route.c 981d142
> src/router_core/connections.c 5fdc3bf
> src/router_core/forwarder.c fca19c3
> src/router_core/route_control.h 3c715bc
> src/router_core/route_control.c 61f426d
> src/router_core/router_core.c 9d7f7a5
> src/router_core/router_core_private.h cd2ffa4
> src/router_core/terminus.c 4c0e0a3
> tests/CMakeLists.txt 159521d
> tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
> tools/qdstat 1e3a3a3
>
>
> Diff: https://reviews.apache.org/r/66839/diff/6/
>
>
> Testing
> -------
>
> Added system tests plus some ad hoc testing.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 66839: translation of remote address in link route
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/
-----------------------------------------------------------
(Updated June 21, 2018, 3:19 p.m.)
Review request for qpid and Ted Ross.
Changes
-------
Added test for qdmanage
Ensure qdstat can still run against older routers
Bugs: DISPATCH-980
https://issues.apache.org/jira/browse/DISPATCH-980
Repository: qpid-dispatch
Description
-------
This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
Diffs (updated)
-----
include/qpid/dispatch/router_core.h 8f144b0
python/qpid_dispatch/management/qdrouter.json 42f501f
src/router_config.c 94758df
src/router_core/agent_config_link_route.h 57f6f0d
src/router_core/agent_config_link_route.c 981d142
src/router_core/connections.c 5fdc3bf
src/router_core/forwarder.c fca19c3
src/router_core/route_control.h 3c715bc
src/router_core/route_control.c 61f426d
src/router_core/router_core.c 9d7f7a5
src/router_core/router_core_private.h cd2ffa4
src/router_core/terminus.c 4c0e0a3
tests/CMakeLists.txt 159521d
tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
tools/qdstat 1e3a3a3
Diff: https://reviews.apache.org/r/66839/diff/6/
Changes: https://reviews.apache.org/r/66839/diff/5-6/
Testing
-------
Added system tests plus some ad hoc testing.
Thanks,
Gordon Sim
Re: Review Request 66839: translation of remote address in link route
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/
-----------------------------------------------------------
(Updated June 20, 2018, 4:25 p.m.)
Review request for qpid and Ted Ross.
Changes
-------
Added new fields to qdstat output; added a test for qdstat change.
Bugs: DISPATCH-980
https://issues.apache.org/jira/browse/DISPATCH-980
Repository: qpid-dispatch
Description
-------
This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
Diffs (updated)
-----
include/qpid/dispatch/router_core.h 8f144b0
python/qpid_dispatch/management/qdrouter.json 42f501f
src/router_config.c 94758df
src/router_core/agent_config_link_route.h 57f6f0d
src/router_core/agent_config_link_route.c 981d142
src/router_core/connections.c 5fdc3bf
src/router_core/forwarder.c fca19c3
src/router_core/route_control.h 3c715bc
src/router_core/route_control.c 61f426d
src/router_core/router_core.c 9d7f7a5
src/router_core/router_core_private.h cd2ffa4
src/router_core/terminus.c 4c0e0a3
tests/CMakeLists.txt 159521d
tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
tools/qdstat 1e3a3a3
Diff: https://reviews.apache.org/r/66839/diff/5/
Changes: https://reviews.apache.org/r/66839/diff/4-5/
Testing
-------
Added system tests plus some ad hoc testing.
Thanks,
Gordon Sim
Re: Review Request 66839: translation of remote address in link route
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/
-----------------------------------------------------------
(Updated June 20, 2018, 2:08 p.m.)
Review request for qpid and Ted Ross.
Changes
-------
Fixed test per review
Bugs: DISPATCH-980
https://issues.apache.org/jira/browse/DISPATCH-980
Repository: qpid-dispatch
Description
-------
This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
Diffs (updated)
-----
include/qpid/dispatch/router_core.h 8f144b0
python/qpid_dispatch/management/qdrouter.json 42f501f
src/router_config.c 94758df
src/router_core/agent_config_link_route.h 57f6f0d
src/router_core/agent_config_link_route.c 981d142
src/router_core/connections.c 5fdc3bf
src/router_core/forwarder.c fca19c3
src/router_core/route_control.h 3c715bc
src/router_core/route_control.c 61f426d
src/router_core/router_core.c 9d7f7a5
src/router_core/router_core_private.h cd2ffa4
src/router_core/terminus.c 4c0e0a3
tests/CMakeLists.txt 159521d
tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
Diff: https://reviews.apache.org/r/66839/diff/4/
Changes: https://reviews.apache.org/r/66839/diff/3-4/
Testing
-------
Added system tests plus some ad hoc testing.
Thanks,
Gordon Sim
Re: Review Request 66839: translation of remote address in link route
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66839/
-----------------------------------------------------------
(Updated June 18, 2018, 9:37 p.m.)
Review request for qpid and Ted Ross.
Changes
-------
Fix to ensure that the two new options can be used together (effectively modifying the address)
Bugs: DISPATCH-980
https://issues.apache.org/jira/browse/DISPATCH-980
Repository: qpid-dispatch
Description
-------
This adds two fields to the link route config, addExternalPrefix and delExternalPrefix, that behave similar to the externalAddr in auto links. I.e. they will cause a prefix to be inserted and/or deleted in the final hop for a link routed link attach. That prefix will also be stripped off or inserted back into the reply, making the renaming completely transparent to clients.
Diffs (updated)
-----
include/qpid/dispatch/router_core.h 8f144b0
python/qpid_dispatch/management/qdrouter.json 42f501f
src/router_config.c 94758df
src/router_core/agent_config_link_route.h 57f6f0d
src/router_core/agent_config_link_route.c 981d142
src/router_core/connections.c 5fdc3bf
src/router_core/forwarder.c fca19c3
src/router_core/route_control.h 3c715bc
src/router_core/route_control.c 61f426d
src/router_core/router_core.c 9d7f7a5
src/router_core/router_core_private.h cd2ffa4
src/router_core/terminus.c 4c0e0a3
tests/CMakeLists.txt 159521d
tests/system_tests_link_routes_add_external_prefix.py PRE-CREATION
Diff: https://reviews.apache.org/r/66839/diff/3/
Changes: https://reviews.apache.org/r/66839/diff/2-3/
Testing
-------
Added system tests plus some ad hoc testing.
Thanks,
Gordon Sim