[GitHub] [pinot] walterddr commented on a diff in pull request #10629: Cleanup unnecessary mailbox id ser/de

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10629:
URL: https://github.com/apache/pinot/pull/10629#discussion_r1169443790


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -42,18 +42,19 @@
  */
 public class GrpcSendingMailbox implements SendingMailbox<TransferableBlock> {
   private static final Logger LOGGER = LoggerFactory.getLogger(GrpcSendingMailbox.class);
-  private final String _mailboxId;
-  private final AtomicBoolean _initialized = new AtomicBoolean(false);
 
-  private StreamObserver<MailboxContent> _mailboxContentStreamObserver;
+  private final String _mailboxId;

Review Comment:
   shouldn't this be MailboxIdentifier type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org