You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airavata.apache.org by GitBox <gi...@apache.org> on 2020/11/27 22:15:22 UTC

[GitHub] [airavata] DImuthuUpe opened a new pull request #268: Fixing AIRAVATA-3391 : Resolving parameters in the groovy map data

DImuthuUpe opened a new pull request #268:
URL: https://github.com/apache/airavata/pull/268


   The current implementation only resolves the parameters in the original groovy template. But if we pass parameters inside the map which contains parameters themselves, those are not resolved. This fix does another pass of parameter parsing on the already generated template output
   
   Related issue: https://issues.apache.org/jira/browse/AIRAVATA-3391


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata] DImuthuUpe merged pull request #268: Fixing AIRAVATA-3391 : Resolving parameters in the groovy map data

Posted by GitBox <gi...@apache.org>.
DImuthuUpe merged pull request #268:
URL: https://github.com/apache/airavata/pull/268


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata] DImuthuUpe edited a comment on pull request #268: Fixing AIRAVATA-3391 : Resolving parameters in the groovy map data

Posted by GitBox <gi...@apache.org>.
DImuthuUpe edited a comment on pull request #268:
URL: https://github.com/apache/airavata/pull/268#issuecomment-737689740


   Merging as there are no outstanding concerns


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata] DImuthuUpe commented on pull request #268: Fixing AIRAVATA-3391 : Resolving parameters in the groovy map data

Posted by GitBox <gi...@apache.org>.
DImuthuUpe commented on pull request #268:
URL: https://github.com/apache/airavata/pull/268#issuecomment-737689466


   For environment variables, use the format \\$parameter to escape $


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata] DImuthuUpe commented on pull request #268: Fixing AIRAVATA-3391 : Resolving parameters in the groovy map data

Posted by GitBox <gi...@apache.org>.
DImuthuUpe commented on pull request #268:
URL: https://github.com/apache/airavata/pull/268#issuecomment-736200743


   > Looks good to me. So the change here is to make two passes at resolving groovy parameters because some groovy map values may reference other parameters?
   
   Yes that's right. One situation that might cause a trouble is referring to environment variables in the pre and post job commands. They are also prefixed using $ and I need to test what will happen in that case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata] DImuthuUpe commented on pull request #268: Fixing AIRAVATA-3391 : Resolving parameters in the groovy map data

Posted by GitBox <gi...@apache.org>.
DImuthuUpe commented on pull request #268:
URL: https://github.com/apache/airavata/pull/268#issuecomment-737689740


   Merging as there is no outstanding concerns


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airavata] DImuthuUpe closed pull request #268: Fixing AIRAVATA-3391 : Resolving parameters in the groovy map data

Posted by GitBox <gi...@apache.org>.
DImuthuUpe closed pull request #268:
URL: https://github.com/apache/airavata/pull/268


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org